<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">RSVP-TE FRR + InterAS could result in 5 label stack (quite a corner case), don’t forget about entropy labels, that come in pairs (ELI, EL).<div class="">Outside of SR-MPLS, 8 labels would be more than enough to cover 99.9% of use cases.</div><div class=""><br class=""></div><div class="">Where are we on SRH (SRv6 data plane)?<br class=""><div class="">
<br class="Apple-interchange-newline"><span style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; display: inline !important; float: none;" class="">Cheers,</span><br style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; display: inline !important; float: none;" class="">Jeff</span><br style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On Mar 23, 2017, at 09:59, Amine Kherbouche <<a href="mailto:amine.kherbouche@6wind.com" class="">amine.kherbouche@6wind.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class=""><div class=""><div class="">Hi David,<br class=""><br class=""></div>I think that 8 stacked labels are more than enough, I cannot imagine a core network with 8 stacked MPLS-VPNs.<span class="Apple-converted-space"> </span><br class="">Let's see the others if they share my opinions.<br class=""><br class=""><br class=""></div>Regards,<br class=""></div>Amine<br class=""></div><div class="gmail_extra" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""><div class="gmail_quote">On 23 March 2017 at 17:47, David Ahern<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:dsa@cumulusnetworks.com" target="_blank" class="">dsa@cumulusnetworks.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">I have the MPLS code changes to bump the number of labels. What did we<br class="">want to use for the max? 12? 16?<br class=""><br class="">This limit is really only capping what we take from userspace. Kernel<br class="">side memory allocations are done based on the actual number of labels in<br class="">the route.<br class=""><div class="HOEnZb"><div class="h5"><br class=""><br class="">On 3/16/17 10:49 AM, Olivier Dugeon wrote:<br class="">> Hi David,<br class="">><br class="">> Well, frankly speaking, I don't see where is the problem regarding the<br class="">> performance.<br class="">><br class="">> IMHO, the patch add an extra size of the array i.e. from 8 bytes (2<br class="">> labels) to 64 bytes (16 labels) which is completely negligible compared<br class="">> to the size of a IP packet, and of same magnitude order as a VxLan<br class="">> encapsulation and twice less as an IPv6 header.<br class="">><br class="">> In addition, only the edge router as to push the label stack. Then,<br class="">> subsequent router just look at the top label. So, no more no less that a<br class="">> packet with only 2 labels in the stack.<br class="">><br class="">> I think that dealing with a dynamic MPLS STACK DEPTH i.e. dynamic memory<br class="">> allocation of space regarding the number of labels are push in from of<br class="">> the IP packet will certainly add more overhead and more CPU cycles<br class="">> rather than just manage a fix amount of byte in an array.<br class="">><br class="">> Finally, the default value for the MPLS_LABEL_STACK could be equal to 2<br class="">> and let peoples want to deal with Segment Routing recompile the kernel<br class="">> with a larger value.<br class="">><br class="">> From my side, your patch will not only increase the label stack, it also<br class="">> re-arrange the MPLS structure in order to solve the problem of corrupted<br class="">> third label. And, this is the more important things.<br class="">><br class="">> In any case, let me know what I can do to help you.<br class="">><br class="">> Regards<br class="">><br class="">> Olivier<br class="">><br class="">><br class="">> Le 16/03/2017 à 16:10, David Ahern a écrit :<br class="">>> I made the kernel patch to help you move along with your MPLS work.<br class="">>><br class="">>> In the kernel thread discussing the increase in number of labels Eric<br class="">>> Biederman mentions performance concerns about just increasing the size<br class="">>> of the array; he wanted a much more complicated change and I have not<br class="">>> gotten around to it.<br class="">>><br class="">>><br class="">>> On 3/16/17 3:31 AM, Olivier Dugeon wrote:<br class="">>>> Hi all,<br class="">>>><br class="">>>> The problem is not between the kernel and iproute2. The problem comes<br class="">>>> when stacking more than 2 labels: the LSB byte of the third label is<br class="">>>> replaced by 0x03 value i.e. the implicit Null Label value. See attached<br class="">>>> thread.<br class="">>>><br class="">>>> Following this, David propose a new patch that we integrated and tested<br class="">>>> successfully (See second and third attached mail).<br class="">>>><br class="">>>> But, after that, I got no news and never seen this patch merge into the<br class="">>>> Linux Kernel release. So, we just ask when this patch could be merge<br class="">>>> into the Linux Kernel.<br class="">>>><br class="">>>> For the second problem about PHP, it is also described in the first<br class="">>>> attached thread. But, agree, that this issue is more tricking to solve.<br class="">>>><br class="">>>> Regards,<br class="">>>><br class="">>>> Olivier<br class="">>>><br class="">>>><br class="">>>> Le 15/03/2017 à 16:59, David Ahern a écrit :<br class="">>>>> On 3/15/17 9:57 AM, Amine Kherbouche wrote:<br class="">>>>>> > 1) More than 2 labels in the kernel at a time, when will this be<br class="">>>>>> > allowed in the kernel?<br class="">>>>>> ><br class="">>>>>><br class="">>>>>> I don't understand why iproute2 and kernel are not sync when it comes to<br class="">>>>>> the max stacked labels, iproute2 should export kernel headers.<br class="">>>>>><br class="">>>>><span class="Apple-converted-space"> </span><a href="https://marc.info/?l=linux-netdev&m=146913202123729&w=2" rel="noreferrer" target="_blank" class="">https://marc.info/?l=linux-<wbr class="">netdev&m=146913202123729&w=2</a><br class="">>>>><br class="">><br class=""></div></div></blockquote></div><br class=""><br clear="all" class=""><br class="">--<span class="Apple-converted-space"> </span><br class=""><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class="">Amine<br class=""></div></div></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">frr mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="mailto:frr@lists.nox.tf" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">frr@lists.nox.tf</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="https://lists.nox.tf/listinfo/frr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">https://lists.nox.tf/listinfo/frr</a></div></blockquote></div><br class=""></div></body></html>