<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style></head><body lang=EN-US link=blue vlink="#954F72"><div class=WordSection1><p class=MsoNormal>I will take care of this in my next patch.</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Regards,</p><p class=MsoNormal>Chirag </p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><div style='mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal style='border:none;padding:0in'><b>From: </b><a href="mailto:scan-admin@coverity.com">scan-admin@coverity.com</a><br><b>Sent: </b>Monday, April 24, 2017 1:38 PM<br><b>To: </b><a href="mailto:frr@lists.nox.tf">frr@lists.nox.tf</a><br><b>Subject: </b>[dev] New Defects reported by Coverity Scan for freerangerouting/frr</p></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Hi,</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.</p><p class=MsoNormal>1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>New defect(s) Reported-by: Coverity Scan</p><p class=MsoNormal>Showing 2 of 2 defect(s)</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>** CID 1430487: Possible Control flow issues (DEADCODE)</p><p class=MsoNormal>/pimd/pim_nht.c: 303 in pim_update_rp_nh()</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>________________________________________________________________________________________________________</p><p class=MsoNormal>*** CID 1430487: Possible Control flow issues (DEADCODE)</p><p class=MsoNormal>/pimd/pim_nht.c: 303 in pim_update_rp_nh()</p><p class=MsoNormal>297 __PRETTY_FUNCTION__, rp_str,</p><p class=MsoNormal>298 rp_info->rp.source_nexthop.interface->name);</p><p class=MsoNormal>299 }</p><p class=MsoNormal>300 }</p><p class=MsoNormal>301 </p><p class=MsoNormal>302 if (ret)</p><p class=MsoNormal>>>> CID 1430487: Possible Control flow issues (DEADCODE)</p><p class=MsoNormal>>>> Execution cannot reach this statement: "return 0;".</p><p class=MsoNormal>303 return 0;</p><p class=MsoNormal>304 </p><p class=MsoNormal>305 return 1;</p><p class=MsoNormal>306 </p><p class=MsoNormal>307 }</p><p class=MsoNormal>308 </p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>** CID 1399390: Security best practices violations (STRING_OVERFLOW)</p><p class=MsoNormal>/pimd/pim_register.c: 193 in pim_register_send()</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>________________________________________________________________________________________________________</p><p class=MsoNormal>*** CID 1399390: Security best practices violations (STRING_OVERFLOW)</p><p class=MsoNormal>/pimd/pim_register.c: 193 in pim_register_send()</p><p class=MsoNormal>187 return;</p><p class=MsoNormal>188 }</p><p class=MsoNormal>189 </p><p class=MsoNormal>190 if (PIM_DEBUG_PIM_REG)</p><p class=MsoNormal>191 {</p><p class=MsoNormal>192 char rp_str[INET_ADDRSTRLEN];</p><p class=MsoNormal>>>> CID 1399390: Security best practices violations (STRING_OVERFLOW)</p><p class=MsoNormal>>>> You might overrun the 16-character fixed-size string "rp_str" by copying the return value of "inet_ntoa" without checking the length.</p><p class=MsoNormal>193 strcpy (rp_str, inet_ntoa (rpg->rpf_addr.u.prefix4));</p><p class=MsoNormal>194 zlog_debug ("%s: Sending %s %sRegister Packet to %s on %s",</p><p class=MsoNormal>195 __PRETTY_FUNCTION__, up->sg_str,</p><p class=MsoNormal>196 null_register ? "NULL " : "", rp_str, ifp->name);</p><p class=MsoNormal>197 }</p><p class=MsoNormal>198 </p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>________________________________________________________________________________________________________</p><p class=MsoNormal>To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmtKHBmrggQsmQ1wRxSAkKp605MA3Ubb6KaJgA7PHUY9nHXRnq5WSc1srjMQBQg4odBhXXoJ44WdRaY6T0BbK3cTZ93VxR-2BRY675i5N7khwYSAZiMnj69VqNo-2BIQ3cG-2FIJXMyXwGoWBgNmkJ0TAudPCXOkllvLB0US1NlmRDyQEdg-3D-3D</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>To manage Coverity Scan email notifications for "frr@lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmtKHBmrggQsmQ1wRxSAkKp8LdK6KIKPaxrr-2FGdwNZ87N8YVJplSMz29-2BtvLyIKy1cIg3WvmDaRQ-2BfxldMSXlOqkyBOVZTUhWbyTnnWii4a1dexsJanRVWL4z1Ro-2FSYtrzYf49fKkvL5OBmTSAEsNoJrXHC6EhzxihVmX753lgDcw-3D-3D</p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>_______________________________________________</p><p class=MsoNormal>dev mailing list</p><p class=MsoNormal>dev@lists.frrouting.org</p><p class=MsoNormal>https://lists.frrouting.org/listinfo/dev</p><p class=MsoNormal><o:p> </o:p></p></div></body></html>