Taking a look at the failing tests in Bamboo and looking at your patch, my guess is that the patch has changed the output of vtysh in such a way that the tests which check for certain strings to be present in vtysh output are failing. This could manifest in non obvious ways - for example, a test that checks BGP convergence may be doing it by looking at the output of "show bgp" and checking that certain strings are present which would indicate a peering. That the tests fail on the master branch locally is a problem. Can you file an issue on Github so we can track that, please? Quentin On 8/26/23 22:30, Yasuhiro Ohara wrote:
Hi. I made a PR (#14278), but my CI run does not finish. Would somebody help me please?
The Bamboo says: ``` Bamboo has detected that FRR-PULLREQ2-TOPO2DEB10AMD64-13825 may have hung. This build has been running for 1475 minutes. This is 4192% longer than usual. It has been 1463 minutes since Bamboo received a log message for this build. ```
From what I can see in the left window of the Bamboo, it appears that builds and AddressSanitizers, etc are finishing okay, but almost all topotests fail, and a few topotests is still running (i.e., hanging).
I tried to topotest in my local env (Ubuntu 22.04.1 LTS), but even original FRR (current master) didn't finish correctly. It says: ``` = 40 failed, 1322 passed, 153 skipped, 7 warnings, 86 errors in 846.82s (0:14:06) = ``` One of the simple tests bgp_asdot_regex fails like: ``` 2023-08-27 11:04:41,563 INFO: topo: Check if neighbor sessions are up in r1 2023-08-27 11:04:49,762 ERROR: topo: '_bgp_converge' failed after 8.20 seconds 2023-08-27 11:04:49,765 ERROR: topo: test failed at "bgp_asdot_regex.test_bgp_as dot_regex/test_bgp_asdot_regex": Failed to see BGP convergence in "r1" ``` where in the setup period it failed to see two BGP routers become Established.
Any help is appreciated. Thanks.
Yasu
_______________________________________________ dev mailing list dev@lists.frrouting.org https://lists.frrouting.org/listinfo/dev