Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1515546: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1515546: Null pointer dereferences (NULL_RETURNS) /pimd/pim_zlookup.c: 391 in zclient_lookup_read_pipe() 385 { 386 struct zclient *zlookup = THREAD_ARG(thread); 387 struct pim_instance *pim = pim_get_pim_instance(VRF_DEFAULT); 388 struct pim_zlookup_nexthop nexthop_tab[10]; 389 struct in_addr l = {.s_addr = INADDR_ANY}; 390
CID 1515546: Null pointer dereferences (NULL_RETURNS) Dereferencing a pointer that might be "NULL" "pim" when calling "zclient_lookup_nexthop_once".
391 zclient_lookup_nexthop_once(pim, nexthop_tab, 10, l); 392 thread_add_timer(router->master, zclient_lookup_read_pipe, zlookup, 60, 393 &zlookup_read); 394 } 395 396 int zclient_lookup_nexthop(struct pim_instance *pim,
** CID 1515545: (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1515545: (NULL_RETURNS) /pimd/pim_vxlan.c: 902 in pim_vxlan_mlag_update() 896 if (vxlan_mlag.peerlink_rif) 897 pim_ifp = (struct pim_interface *)vxlan_mlag.peerlink_rif->info; 898 if ((vxlan_mlag.flags & PIM_VXLAN_MLAGF_ENABLED) && 899 pim_ifp && (pim_ifp->mroute_vif_index > 0)) 900 pim_vxlan_set_peerlink_rif(pim, peerlink_rif); 901 else
CID 1515545: (NULL_RETURNS) Dereferencing a pointer that might be "NULL" "pim" when calling "pim_vxlan_set_peerlink_rif".
902 pim_vxlan_set_peerlink_rif(pim, NULL); 903 } 904 905 /****************************** misc callbacks *******************************/ 906 static void pim_vxlan_set_default_iif(struct pim_instance *pim, 907 struct interface *ifp) /pimd/pim_vxlan.c: 900 in pim_vxlan_mlag_update() 894 895 /* process changes */ 896 if (vxlan_mlag.peerlink_rif) 897 pim_ifp = (struct pim_interface *)vxlan_mlag.peerlink_rif->info; 898 if ((vxlan_mlag.flags & PIM_VXLAN_MLAGF_ENABLED) && 899 pim_ifp && (pim_ifp->mroute_vif_index > 0))
CID 1515545: (NULL_RETURNS) Dereferencing a pointer that might be "NULL" "pim" when calling "pim_vxlan_set_peerlink_rif".
900 pim_vxlan_set_peerlink_rif(pim, peerlink_rif); 901 else 902 pim_vxlan_set_peerlink_rif(pim, NULL); 903 } 904 905 /****************************** misc callbacks *******************************/
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...