Since I keep having to *fix* the broken cli that people keep submitting, I would rather break the build's until things are fixed than having to catch and fix the issue myself instead of the person submitting the work. It's just making busy work for me and I'm tired of it. In any event the patches to fix *this* broke behavior are in. donald On Thu, Apr 6, 2017 at 4:38 AM, Martin Winter <mwinter@opensourcerouting.org> wrote:
On 5 Apr 2017, at 20:11, Donald Sharp wrote:
All -
I keep finding and having to fix broken cli issues found by simply running vtysh:
sharpd@robot ~/frr> sudo vtysh 2017/04/05 23:08:07 unknown: Ran out of docstring while parsing 'distribute-list [prefix] WORD <in|out> [WORD]' 2017/04/05 23:08:07 unknown: Ran out of docstring while parsing 'no [ipv6] distribute-list [prefix] WORD <in|out> [WORD]' 2017/04/05 23:08:07 unknown: Ran out of docstring while parsing 'no [ipv6] distribute-list [prefix] WORD <in|out> [WORD]' 2017/04/05 23:08:07 unknown: Ran out of docstring while parsing 'distribute-list [prefix] WORD <in|out> [WORD]'
Please take a moment to at least *run* vtysh before you push something up for a Pull Request.
Martin -
I know a month or so back I asked to have some CI coverage of this issue. Is it possible to get something turned on?
First: Sorry… got way too many things sidetracking me. But I’ll get it done this weekend latest.
Second: Turning it on would require the existing bugs fixed first - or all pull requests will fail.
- Martin