Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1499606: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2595 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_prefix_list_modify() ________________________________________________________________________________________________________ *** CID 1499606: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2595 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_prefix_list_modify() 2589 break; 2590 case NB_EV_APPLY: 2591 vrf = nb_running_get_entry(args->dnode, NULL, true); 2592 pim = vrf->info; 2593 plist = yang_dnode_get_string(args->dnode, NULL); 2594 yang_dnode_get_ip(&rp_addr, args->dnode, "../rp-address");
CID 1499606: Error handling issues (CHECKED_RETURN) Calling "str2prefix" without checking return value (as is done elsewhere 58 out of 61 times).
2595 str2prefix("224.0.0.0/4", &group); 2596 return pim_rp_cmd_worker(pim, rp_addr.ip._v4_addr, group, 2597 plist, args->errmsg, args->errmsg_len); 2598 } 2599 2600 return NB_OK;
** CID 1499605: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2500 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_destroy() ________________________________________________________________________________________________________ *** CID 1499605: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2500 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_destroy() 2494 args->errmsg_len); 2495 } 2496 2497 else if (yang_dnode_get(args->dnode, "./prefix-list")) { 2498 plist = yang_dnode_get_string(args->dnode, 2499 "./prefix-list");
CID 1499605: Error handling issues (CHECKED_RETURN) Calling "str2prefix" without checking return value (as is done elsewhere 58 out of 61 times).
2500 str2prefix("224.0.0.0/4", &group); 2501 result = pim_no_rp_cmd_worker(pim, rp_addr.ip._v4_addr, 2502 group, plist, 2503 args->errmsg, 2504 args->errmsg_len); 2505 }
** CID 1499604: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2622 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_prefix_list_destroy() ________________________________________________________________________________________________________ *** CID 1499604: Error handling issues (CHECKED_RETURN) /pimd/pim_nb_config.c: 2622 in routing_control_plane_protocols_control_plane_protocol_pim_address_family_rp_static_rp_rp_list_prefix_list_destroy() 2616 break; 2617 case NB_EV_APPLY: 2618 vrf = nb_running_get_entry(args->dnode, NULL, true); 2619 pim = vrf->info; 2620 yang_dnode_get_ip(&rp_addr, args->dnode, "../rp-address"); 2621 plist = yang_dnode_get_string(args->dnode, NULL);
CID 1499604: Error handling issues (CHECKED_RETURN) Calling "str2prefix" without checking return value (as is done elsewhere 58 out of 61 times).
2622 str2prefix("224.0.0.0/4", &group); 2623 return pim_no_rp_cmd_worker(pim, rp_addr.ip._v4_addr, group, 2624 plist, args->errmsg, 2625 args->errmsg_len); 2626 break; 2627 }
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...