Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1424529: (FORWARD_NULL) /isisd/isis_lsp.c: 1654 in lsp_build() /isisd/isis_lsp.c: 1710 in lsp_build() ________________________________________________________________________________________________________ *** CID 1424529: (FORWARD_NULL) /isisd/isis_lsp.c: 1654 in lsp_build() 1648 lsp_debug("ISIS (%s): No DIS for circuit, not adding te-style IS neighbor.", 1649 area->area_tag); 1650 } 1651 else 1652 { 1653 /* Check if MPLS_TE is activate */
CID 1424529: (FORWARD_NULL) Dereferencing null pointer "circuit->interface".
1654 if (IS_MPLS_TE(isisMplsTE) && HAS_LINK_PARAMS(circuit->interface)) 1655 /* Add SubTLVs & Adjust real size of SubTLVs */ 1656 te_is_neigh->sub_tlvs_length = add_te_subtlvs(te_is_neigh->sub_tlvs, circuit->mtc); 1657 else 1658 /* Or keep only TE metric with no SubTLVs if MPLS_TE is off */ 1659 te_is_neigh->sub_tlvs_length = 0; /isisd/isis_lsp.c: 1710 in lsp_build() 1704 te_is_neigh = XCALLOC (MTYPE_ISIS_TLV, 1705 sizeof (struct te_is_neigh)); 1706 memcpy (te_is_neigh->neigh_id, nei->sysid, ISIS_SYS_ID_LEN); 1707 metric = circuit->te_metric[level - 1]; 1708 SET_TE_METRIC(te_is_neigh, metric); 1709 /* Check if MPLS_TE is activate */
CID 1424529: (FORWARD_NULL) Dereferencing null pointer "circuit->interface".
1710 if (IS_MPLS_TE(isisMplsTE) && HAS_LINK_PARAMS(circuit->interface)) 1711 /* Update Local and Remote IP address for MPLS TE circuit parameters */ 1712 /* NOTE sure that it is the pertinent place for that updates */ 1713 /* Local IP address could be updated in isis_circuit.c - isis_circuit_add_addr() */ 1714 /* But, where update remote IP address ? in isis_pdu.c - process_p2p_hello() ? */ 1715
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05... To manage Coverity Scan email notifications for "frr@lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...