Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1431864: (NO_EFFECT) /ldpd/ldpe.c: 146 in ldpe_init() /ldpd/ldpe.c: 148 in ldpe_init() ________________________________________________________________________________________________________ *** CID 1431864: (NO_EFFECT) /ldpd/ldpe.c: 146 in ldpe_init() 140 } 141 142 void 143 ldpe_init(struct ldpd_init *init) 144 { 145 /* drop privileges */
CID 1431864: (NO_EFFECT) Comparing an array to null is not useful: "init->user", since the test will always evaluate as true.
146 if (init->user) 147 ldpe_privs.user = init->user; 148 if (init->group) 149 ldpe_privs.group = init->group; 150 zprivs_init(&ldpe_privs); 151 /ldpd/ldpe.c: 148 in ldpe_init() 142 void 143 ldpe_init(struct ldpd_init *init) 144 { 145 /* drop privileges */ 146 if (init->user) 147 ldpe_privs.user = init->user;
CID 1431864: (NO_EFFECT) Comparing an array to null is not useful: "init->group", since the test will always evaluate as true.
148 if (init->group) 149 ldpe_privs.group = init->group; 150 zprivs_init(&ldpe_privs); 151 152 /* listen on ldpd control socket */ 153 strlcpy(ctl_sock_path, init->ctl_sock_path, sizeof(ctl_sock_path));
** CID 1431863: (NO_EFFECT) /ldpd/lde.c: 167 in lde_init() /ldpd/lde.c: 169 in lde_init() ________________________________________________________________________________________________________ *** CID 1431863: (NO_EFFECT) /ldpd/lde.c: 167 in lde_init() 161 } 162 163 void 164 lde_init(struct ldpd_init *init) 165 { 166 /* drop privileges */
CID 1431863: (NO_EFFECT) Comparing an array to null is not useful: "init->user", since the test will always evaluate as true.
167 if (init->user) 168 lde_privs.user = init->user; 169 if (init->group) 170 lde_privs.group = init->group; 171 zprivs_init(&lde_privs); 172 /ldpd/lde.c: 169 in lde_init() 163 void 164 lde_init(struct ldpd_init *init) 165 { 166 /* drop privileges */ 167 if (init->user) 168 lde_privs.user = init->user;
CID 1431863: (NO_EFFECT) Comparing an array to null is not useful: "init->group", since the test will always evaluate as true.
169 if (init->group) 170 lde_privs.group = init->group; 171 zprivs_init(&lde_privs); 172 173 #ifdef HAVE_PLEDGE 174 if (pledge("stdio recvfd unix", NULL) == -1)
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05... To manage Coverity Scan email notifications for "frr@lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...