Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1576137: (UNUSED_VALUE) /pceplib/test/pcep_msg_tlvs_test.c: 202 in test_pcep_tlv_create_path_setup_type_capability() /pceplib/test/pcep_msg_tlvs_test.c: 184 in test_pcep_tlv_create_path_setup_type_capability() /pceplib/test/pcep_msg_tlvs_test.c: 193 in test_pcep_tlv_create_path_setup_type_capability() ________________________________________________________________________________________________________ *** CID 1576137: (UNUSED_VALUE) /pceplib/test/pcep_msg_tlvs_test.c: 202 in test_pcep_tlv_create_path_setup_type_capability() 196 /* Should still return NULL if pst_list is empty */ 197 tlv = pcep_tlv_create_path_setup_type_capability(pst_list, 198 sub_tlv_list); 199 CU_ASSERT_PTR_NULL(tlv); 200 if (tlv != NULL) { 201 pcep_obj_free_tlv(&tlv->header);
CID 1576137: (UNUSED_VALUE) Assigning value "NULL" to "tlv" here, but that stored value is overwritten before it can be used.
202 tlv = NULL; 203 } 204 205 /* Test only populating the pst list */ 206 uint8_t *pst1 = pceplib_malloc(PCEPLIB_MESSAGES, 1); 207 uint8_t *pst2 = pceplib_malloc(PCEPLIB_MESSAGES, 1); /pceplib/test/pcep_msg_tlvs_test.c: 184 in test_pcep_tlv_create_path_setup_type_capability() 178 /* Should return NULL if pst_list is empty */ 179 double_linked_list *pst_list = dll_initialize(); 180 tlv = pcep_tlv_create_path_setup_type_capability(pst_list, NULL); 181 CU_ASSERT_PTR_NULL(tlv); 182 if (tlv != NULL) { 183 pcep_obj_free_tlv(&tlv->header);
CID 1576137: (UNUSED_VALUE) Assigning value "NULL" to "tlv" here, but that stored value is overwritten before it can be used.
184 tlv = NULL; 185 } 186 187 /* Should still return NULL if pst_list is NULL */ 188 double_linked_list *sub_tlv_list = dll_initialize(); 189 tlv = pcep_tlv_create_path_setup_type_capability(NULL, sub_tlv_list); /pceplib/test/pcep_msg_tlvs_test.c: 193 in test_pcep_tlv_create_path_setup_type_capability() 187 /* Should still return NULL if pst_list is NULL */ 188 double_linked_list *sub_tlv_list = dll_initialize(); 189 tlv = pcep_tlv_create_path_setup_type_capability(NULL, sub_tlv_list); 190 CU_ASSERT_PTR_NULL(tlv); 191 if (tlv != NULL) { 192 pcep_obj_free_tlv(&tlv->header);
CID 1576137: (UNUSED_VALUE) Assigning value "NULL" to "tlv" here, but that stored value is overwritten before it can be used.
193 tlv = NULL; 194 } 195 196 /* Should still return NULL if pst_list is empty */ 197 tlv = pcep_tlv_create_path_setup_type_capability(pst_list, 198 sub_tlv_list);
** CID 1576136: Code maintainability issues (UNUSED_VALUE) /pceplib/test/pcep_msg_tlvs_test.c: 110 in test_pcep_tlv_create_speaker_entity_id() ________________________________________________________________________________________________________ *** CID 1576136: Code maintainability issues (UNUSED_VALUE) /pceplib/test/pcep_msg_tlvs_test.c: 110 in test_pcep_tlv_create_speaker_entity_id() 104 105 double_linked_list *list = dll_initialize(); 106 tlv = pcep_tlv_create_speaker_entity_id(list); 107 CU_ASSERT_PTR_NULL(tlv); 108 if (tlv != NULL) { 109 pceplib_free(PCEPLIB_INFRA, tlv);
CID 1576136: Code maintainability issues (UNUSED_VALUE) Assigning value "NULL" to "tlv" here, but that stored value is overwritten before it can be used.
110 tlv = NULL; 111 } 112 113 uint32_t *speaker_entity = 114 pceplib_malloc(PCEPLIB_MESSAGES, sizeof(uint32_t)); 115 *speaker_entity = 42;
** CID 1576135: (UNUSED_VALUE) /pceplib/test/pcep_msg_messages_test.c: 403 in test_pcep_msg_create_update() /pceplib/test/pcep_msg_messages_test.c: 422 in test_pcep_msg_create_update() ________________________________________________________________________________________________________ *** CID 1576135: (UNUSED_VALUE) /pceplib/test/pcep_msg_messages_test.c: 403 in test_pcep_msg_create_update() 397 398 /* Should return NULL if obj_list is empty */ 399 message = pcep_msg_create_update(obj_list); 400 CU_ASSERT_PTR_NULL(message); 401 if (message != NULL) { 402 pcep_msg_free_message(message);
CID 1576135: (UNUSED_VALUE) Assigning value "NULL" to "message" here, but that stored value is overwritten before it can be used.
403 message = NULL; 404 } 405 406 struct pcep_object_srp *srp = pcep_obj_create_srp(false, 100, NULL); 407 struct pcep_object_lsp *lsp = 408 pcep_obj_create_lsp(100, PCEP_LSP_OPERATIONAL_UP, true, true, /pceplib/test/pcep_msg_messages_test.c: 422 in test_pcep_msg_create_update() 416 message = pcep_msg_create_update(obj_list); 417 CU_ASSERT_PTR_NULL(message); 418 419 dll_append(obj_list, ero); 420 if (message != NULL) { 421 pcep_msg_free_message(message);
CID 1576135: (UNUSED_VALUE) Assigning value "NULL" to "message" here, but that stored value is overwritten before it can be used.
422 message = NULL; 423 } 424 message = pcep_msg_create_update(obj_list); 425 CU_ASSERT_PTR_NOT_NULL(message); 426 pcep_encode_message(message, versioning); 427 assert(message != NULL);
** CID 1576134: (UNUSED_VALUE) /pceplib/test/pcep_msg_messages_test.c: 471 in test_pcep_msg_create_initiate() /pceplib/test/pcep_msg_messages_test.c: 455 in test_pcep_msg_create_initiate() ________________________________________________________________________________________________________ *** CID 1576134: (UNUSED_VALUE) /pceplib/test/pcep_msg_messages_test.c: 471 in test_pcep_msg_create_initiate() 465 /* Should return NULL if obj_list does not have 2 entries */ 466 dll_append(obj_list, srp); 467 message = pcep_msg_create_initiate(obj_list); 468 CU_ASSERT_PTR_NULL(message); 469 if (message != NULL) { 470 pcep_msg_free_message(message);
CID 1576134: (UNUSED_VALUE) Assigning value "NULL" to "message" here, but that stored value is overwritten before it can be used.
471 message = NULL; 472 } 473 474 dll_append(obj_list, lsp); 475 dll_append(obj_list, ero); 476 message = pcep_msg_create_initiate(obj_list); /pceplib/test/pcep_msg_messages_test.c: 455 in test_pcep_msg_create_initiate() 449 450 /* Should return NULL if obj_list is empty */ 451 struct pcep_message *message = pcep_msg_create_initiate(NULL); 452 CU_ASSERT_PTR_NULL(message); 453 if (message != NULL) { 454 pcep_msg_free_message(message);
CID 1576134: (UNUSED_VALUE) Assigning value "NULL" to "message" here, but that stored value is overwritten before it can be used.
455 message = NULL; 456 } 457 458 struct pcep_object_srp *srp = pcep_obj_create_srp(false, 100, NULL); 459 struct pcep_object_lsp *lsp = 460 pcep_obj_create_lsp(100, PCEP_LSP_OPERATIONAL_UP, true, true,
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...