Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1463851: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_evpn.c: 395 in map_vrf_to_rt() ________________________________________________________________________________________________________ *** CID 1463851: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_evpn.c: 395 in map_vrf_to_rt() 389 memcpy(&eval_tmp, eval, ECOMMUNITY_SIZE); 390 if (!CHECK_FLAG(bgp_vrf->vrf_flags, 391 BGP_VRF_IMPORT_RT_CFGD)) 392 mask_ecom_global_admin(&eval_tmp, eval); 393 394 irt = lookup_vrf_import_rt(&eval_tmp);
CID 1463851: Null pointer dereferences (FORWARD_NULL) Comparing "irt->vrfs" to null implies that "irt->vrfs" might be null.
395 if (irt && irt->vrfs) 396 if (is_vrf_present_in_irt_vrfs(irt->vrfs, bgp_vrf)) 397 /* Already mapped. */ 398 return; 399 400 if (!irt) {
** CID 1463850: Error handling issues (CHECKED_RETURN) /bgpd/bgp_evpn.c: 3808 in bgp_evpn_derive_auto_rd_for_vrf() ________________________________________________________________________________________________________ *** CID 1463850: Error handling issues (CHECKED_RETURN) /bgpd/bgp_evpn.c: 3808 in bgp_evpn_derive_auto_rd_for_vrf() 3802 { 3803 char buf[100]; 3804 3805 bgp->vrf_prd.family = AF_UNSPEC; 3806 bgp->vrf_prd.prefixlen = 64; 3807 sprintf(buf, "%s:%hu", inet_ntoa(bgp->router_id), bgp->vrf_rd_id);
CID 1463850: Error handling issues (CHECKED_RETURN) Calling "str2prefix_rd" without checking return value (as is done elsewhere 14 out of 15 times).
3808 str2prefix_rd(buf, &bgp->vrf_prd); 3809 } 3810 3811 /* 3812 * Derive RD automatically for VNI using passed information - it 3813 * is of the form RouterId:unique-id-for-vni.
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05... To manage Coverity Scan email notifications for "frr@lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...