Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1469463: Incorrect expression (CONSTANT_EXPRESSION_RESULT) /bgpd/bgp_pbr.c: 243 in bgp_pbr_validate_policy_route() ________________________________________________________________________________________________________ *** CID 1469463: Incorrect expression (CONSTANT_EXPRESSION_RESULT) /bgpd/bgp_pbr.c: 243 in bgp_pbr_validate_policy_route() 237 * for now, only match/set supported is 238 * - combination src/dst => redirect nexthop [ + rate] 239 * - combination src/dst => redirect VRF [ + rate] 240 * - combination src/dst => drop 241 * - combination srcport + @IP 242 */
CID 1469463: Incorrect expression (CONSTANT_EXPRESSION_RESULT) The expression "api->match_icmp_type_num || api->match_icmp_type_num" does not accomplish anything because it evaluates to either of its identical operands, "api->match_icmp_type_num".
243 if (api->match_icmp_type_num || api->match_icmp_type_num 244 || api->match_packet_length_num || api->match_dscp_num 245 || api->match_tcpflags_num) { 246 if (BGP_DEBUG(pbr, PBR)) { 247 bgp_pbr_print_policy_route(api); 248 zlog_debug("BGP: some SET actions not supported by Zebra. ignoring.");
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...