New Defects reported by Coverity Scan for freerangerouting/frr
Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1457301: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_te.c: 1172 in ospf_mpls_te_lsa_new() ________________________________________________________________________________________________________ *** CID 1457301: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_te.c: 1172 in ospf_mpls_te_lsa_new() 1166 lsa_type = OSPF_OPAQUE_AREA_LSA; 1167 } 1168 tmp = SET_OPAQUE_LSID(OPAQUE_TYPE_INTER_AS_LSA, lp->instance); 1169 lsa_id.s_addr = htonl(tmp); 1170 1171 if (!ospf)
CID 1457301: Resource leaks (RESOURCE_LEAK) Variable "s" going out of scope leaks the storage it points to.
1172 return NULL; 1173 1174 lsa_header_set(s, options, lsa_type, lsa_id, ospf->router_id); 1175 } else { 1176 options |= LSA_OPTIONS_GET(area); /* Get area default option */ 1177 options |= LSA_OPTIONS_NSSA_GET(area);
** CID 1457300: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_vty.c: 8730 in config_write_interface_one() ________________________________________________________________________________________________________ *** CID 1457300: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_vty.c: 8730 in config_write_interface_one() 8724 vty_out(vty, " %s", 8725 inet_ntoa(rn->p.u.prefix4)); 8726 vty_out(vty, "\n"); 8727 } 8728 8729 /* Cryptographic Authentication Key print. */
CID 1457300: Null pointer dereferences (FORWARD_NULL) Comparing "params" to null implies that "params" might be null.
8730 if (params && params->auth_crypt) { 8731 for (ALL_LIST_ELEMENTS_RO(params->auth_crypt, 8732 n2, ck)) { 8733 vty_out(vty, 8734 " ip ospf message-digest-key %d md5 %s", 8735 ck->key_id, ck->auth_key);
** CID 1457299: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_ri.c: 664 in ospf_router_info_lsa_originate1() ________________________________________________________________________________________________________ *** CID 1457299: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_ri.c: 664 in ospf_router_info_lsa_originate1() 658 659 /* Get ospf info */ 660 top = ospf_lookup_by_vrf_id(vrf_id); 661 if (top == NULL) { 662 zlog_debug("%s: ospf instance not found for vrf id %u", 663 __PRETTY_FUNCTION__, vrf_id);
CID 1457299: Resource leaks (RESOURCE_LEAK) Variable "new" going out of scope leaks the storage it points to.
664 return rc; 665 } 666 667 /* Install this LSA into LSDB. */ 668 if (ospf_lsa_install(top, NULL /*oi */, new) == NULL) { 669 zlog_warn(
** CID 1457298: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_network.c: 268 in ospf_sock_init() ________________________________________________________________________________________________________ *** CID 1457298: Resource leaks (RESOURCE_LEAK) /ospfd/ospf_network.c: 268 in ospf_sock_init() 262 ospf->fd = ospf_sock; 263 out: 264 if (ospfd_privs.change(ZPRIVS_LOWER)) { 265 zlog_err("ospf_sock_init: could not lower privs, %s", 266 safe_strerror(errno)); 267 }
CID 1457298: Resource leaks (RESOURCE_LEAK) Handle variable "ospf_sock" going out of scope leaks the handle.
268 return ret;
** CID 1457297: (RESOURCE_LEAK) /ospfd/ospf_zebra.c: 1140 in ospf_distribute_list_update() /ospfd/ospf_zebra.c: 1144 in ospf_distribute_list_update() ________________________________________________________________________________________________________ *** CID 1457297: (RESOURCE_LEAK) /ospfd/ospf_zebra.c: 1140 in ospf_distribute_list_update() 1134 args[0] = ospf; 1135 args[1] = (void *)((ptrdiff_t) type); 1136 1137 /* External info does not exist. */ 1138 ext = ospf_external_lookup(type, instance); 1139 if (!ext || !(rt = EXTERNAL_INFO(ext)))
CID 1457297: (RESOURCE_LEAK) Variable "args" going out of scope leaks the storage it points to.
1140 return; 1141 1142 /* If exists previously invoked thread, then let it continue. */ 1143 if (ospf->t_distribute_update) 1144 return; 1145 /ospfd/ospf_zebra.c: 1144 in ospf_distribute_list_update() 1138 ext = ospf_external_lookup(type, instance); 1139 if (!ext || !(rt = EXTERNAL_INFO(ext))) 1140 return; 1141 1142 /* If exists previously invoked thread, then let it continue. */ 1143 if (ospf->t_distribute_update)
CID 1457297: (RESOURCE_LEAK) Variable "args" going out of scope leaks the storage it points to.
1144 return; 1145 1146 /* Set timer. */ 1147 ospf->t_distribute_update = NULL; 1148 thread_add_timer_msec(master, ospf_distribute_list_update_timer, 1149 (void **)args, ospf->min_ls_interval,
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05... To manage Coverity Scan email notifications for "frr@lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...
participants (1)
-
scan-admin＠coverity.com