[frr] New Defects reported by Coverity Scan for freerangerouting/frr
Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1420923: Null pointer dereferences (REVERSE_INULL) /pimd/pim_msg.c: 112 in pim_msg_get_jp_group_size() ________________________________________________________________________________________________________ *** CID 1420923: Null pointer dereferences (REVERSE_INULL) /pimd/pim_msg.c: 112 in pim_msg_get_jp_group_size() 106 107 size += sizeof (struct pim_encoded_group_ipv4); 108 size += 4; // Joined sources (2) + Pruned Sources (2) 109 110 size += sizeof (struct pim_encoded_source_ipv4) * sources->count; 111
CID 1420923: Null pointer dereferences (REVERSE_INULL) Null-checking "sources" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
112 js = listgetdata(listhead(sources)); 113 if (js && js->up->sg.src.s_addr == INADDR_ANY) 114 { 115 struct pim_upstream *child, *up; 116 struct listnode *up_node; 117
** CID 742780: Memory - corruptions (ARRAY_VS_SINGLETON) /ospf6d/ospf6_route.c: 948 in ospf6_route_match_head() ________________________________________________________________________________________________________ *** CID 742780: Memory - corruptions (ARRAY_VS_SINGLETON) /ospf6d/ospf6_route.c: 948 in ospf6_route_match_head() 942 struct ospf6_route *route; 943 944 /* Walk down tree. */ 945 node = table->table->top; 946 while (node && node->p.prefixlen < prefix->prefixlen && 947 prefix_match (&node->p, prefix))
CID 742780: Memory - corruptions (ARRAY_VS_SINGLETON) Taking address with "&prefix->u.prefix" yields a singleton pointer.
948 node = node->link[prefix_bit(&prefix->u.prefix, node->p.prefixlen)]; 949 950 if (node) 951 route_lock_node (node); 952 while (node && node->info == NULL) 953 node = route_next (node);
** CID 742779: Memory - corruptions (ARRAY_VS_SINGLETON) /ospf6d/ospf6_lsdb.c: 252 in ospf6_lsdb_lookup_next() ________________________________________________________________________________________________________ *** CID 742779: Memory - corruptions (ARRAY_VS_SINGLETON) /ospf6d/ospf6_lsdb.c: 252 in ospf6_lsdb_lookup_next() 246 node = lsdb->table->top; 247 /* walk down tree. */ 248 while (node && node->p.prefixlen <= p->prefixlen && 249 prefix_match (&node->p, p)) 250 { 251 matched = node;
CID 742779: Memory - corruptions (ARRAY_VS_SINGLETON) Taking address with "&p->u.prefix" yields a singleton pointer.
252 node = node->link[prefix_bit(&p->u.prefix, node->p.prefixlen)]; 253 } 254 255 if (matched) 256 node = matched; 257 else
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05... To manage Coverity Scan email notifications for "frr@lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...
participants (1)
-
scan-admin@coverity.com