Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 78 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1455230: Resource leaks (RESOURCE_LEAK) /eigrpd/eigrp_packet.c: 275 in eigrp_make_sha256_digest() ________________________________________________________________________________________________________ *** CID 1455230: Resource leaks (RESOURCE_LEAK) /eigrpd/eigrp_packet.c: 275 in eigrp_make_sha256_digest() 269 if (keychain) 270 key = key_lookup_for_send(keychain); 271 272 if (!key) { 273 zlog_warn("Interface %s: Expected key value not found in config", 274 ei->ifp->name);

...

...

CID 1455230: Resource leaks (RESOURCE_LEAK) Variable "auth_TLV" going out of scope leaks the storage it points to.

275 return 0; 276 } 277 278 inet_ntop(AF_INET, &ei->address->u.prefix4, source_ip, PREFIX_STRLEN); 279 280 memset(&ctx, 0, sizeof(ctx));

** CID 1455229: (BUFFER_SIZE_WARNING) /eigrpd/eigrp_packet.c: 625 in eigrp_read() /eigrpd/eigrp_packet.c: 626 in eigrp_read() ________________________________________________________________________________________________________ *** CID 1455229: (BUFFER_SIZE_WARNING) /eigrpd/eigrp_packet.c: 625 in eigrp_read() 619 start of the eigrp TLVs */ 620 opcode = eigrph->opcode; 621 622 if (IS_DEBUG_EIGRP_TRANSMIT(0, RECV)) { 623 char src[PREFIX_STRLEN], dst[PREFIX_STRLEN]; 624

...

...

CID 1455229: (BUFFER_SIZE_WARNING) Calling strncpy with a maximum size argument of 51 bytes on destination array "src" of size 51 bytes might leave the destination string unterminated.

625 strncpy(src, inet_ntoa(iph->ip_src), PREFIX_STRLEN); 626 strncpy(dst, inet_ntoa(iph->ip_dst), PREFIX_STRLEN); 627 zlog_debug("Received [%s][%d/%d] length [%u] via [%s] src [%s] dst [%s]", 628 lookup_msg(eigrp_packet_type_str, opcode, NULL), 629 ntohl(eigrph->sequence), ntohl(eigrph->ack), length, 630 IF_NAME(ei), src, dst); /eigrpd/eigrp_packet.c: 626 in eigrp_read() 620 opcode = eigrph->opcode; 621 622 if (IS_DEBUG_EIGRP_TRANSMIT(0, RECV)) { 623 char src[PREFIX_STRLEN], dst[PREFIX_STRLEN]; 624 625 strncpy(src, inet_ntoa(iph->ip_src), PREFIX_STRLEN);

...

CID 1455229: (BUFFER_SIZE_WARNING) Calling strncpy with a maximum size argument of 51 bytes on destination array "dst" of size 51 bytes might leave the destination string unterminated.

626 strncpy(dst, inet_ntoa(iph->ip_dst), PREFIX_STRLEN); 627 zlog_debug("Received [%s][%d/%d] length [%u] via [%s] src [%s] dst [%s]", 628 lookup_msg(eigrp_packet_type_str, opcode, NULL), 629 ntohl(eigrph->sequence), ntohl(eigrph->ack), length, 630 IF_NAME(ei), src, dst); 631 }

________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05... To manage Coverity Scan email notifications for "frr@lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...