[cmaster-next] [PATCH] Rationalize Link Parameters flags
Rationalize Link Parameters flags * lib/if.h: Remove LP_TE as Link Parameters is set if different from 0 See IS_LINK_PARAMS_SET macro and use LP_TE_METRIC to determine if TE metric is set or not * lib/if.c: replace LP_TE by LP_TE_METRIC in default LP status * zebra/interface.c: replace LP_TE by LP_TE_METRIC and check if TE metric is equal to standard metric or not * ospfd/ospf_te.c: replace LP_TE by LP_TE_METRIC * isisd/isis_te.c: replace LP_TE by LP_TE_METRIC Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com> --- isisd/isis_te.c | 2 +- lib/if.c | 4 ++-- lib/if.h | 9 ++++++--- ospfd/ospf_te.c | 2 +- zebra/interface.c | 8 ++++---- 5 files changed, 14 insertions(+), 11 deletions(-)
Should we keep active patchsets on cmaster-next or start from now on frr's git? Le 20/12/2016 à 15:20, Olivier Dugeon a écrit :
Rationalize Link Parameters flags
* lib/if.h: Remove LP_TE as Link Parameters is set if different from 0 See IS_LINK_PARAMS_SET macro and use LP_TE_METRIC to determine if TE metric is set or not * lib/if.c: replace LP_TE by LP_TE_METRIC in default LP status * zebra/interface.c: replace LP_TE by LP_TE_METRIC and check if TE metric is equal to standard metric or not * ospfd/ospf_te.c: replace LP_TE by LP_TE_METRIC * isisd/isis_te.c: replace LP_TE by LP_TE_METRIC
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com> --- isisd/isis_te.c | 2 +- lib/if.c | 4 ++-- lib/if.h | 9 ++++++--- ospfd/ospf_te.c | 2 +- zebra/interface.c | 8 ++++---- 5 files changed, 14 insertions(+), 11 deletions(-)
_______________________________________________ cmaster-next mailing list cmaster-next@lists.nox.tf https://lists.nox.tf/listinfo/cmaster-next
Hello Vincent, Don't know. I just based my patch in latest frr, but used the mailing list to send it instead of Pull Request, or directly commit. I prefer to wait acknowledge from David or Donald before pushing the code in the master. Regards Olivier Le 20/12/2016 à 15:22, Vincent JARDIN a écrit :
Should we keep active patchsets on cmaster-next or start from now on frr's git?
Le 20/12/2016 à 15:20, Olivier Dugeon a écrit :
Rationalize Link Parameters flags
* lib/if.h: Remove LP_TE as Link Parameters is set if different from 0 See IS_LINK_PARAMS_SET macro and use LP_TE_METRIC to determine if TE metric is set or not * lib/if.c: replace LP_TE by LP_TE_METRIC in default LP status * zebra/interface.c: replace LP_TE by LP_TE_METRIC and check if TE metric is equal to standard metric or not * ospfd/ospf_te.c: replace LP_TE by LP_TE_METRIC * isisd/isis_te.c: replace LP_TE by LP_TE_METRIC
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com> --- isisd/isis_te.c | 2 +- lib/if.c | 4 ++-- lib/if.h | 9 ++++++--- ospfd/ospf_te.c | 2 +- zebra/interface.c | 8 ++++---- 5 files changed, 14 insertions(+), 11 deletions(-)
_______________________________________________ cmaster-next mailing list cmaster-next@lists.nox.tf https://lists.nox.tf/listinfo/cmaster-next
_______________________________________________ cmaster-next mailing list cmaster-next@lists.nox.tf https://lists.nox.tf/listinfo/cmaster-next
Le 20/12/2016 à 15:34, Olivier Dugeon a écrit :
but used the mailing list to send it instead of Pull Request, or good pratice, we shall not commit hidden patches without going thru the mailing list or pull request (both are fine for me), till it has been ack't without any nack. Patchwork would help.
directly commit.
Your patch is an ack for me, you are welcomed to push.
Vincent, Le 20/12/2016 à 15:39, Vincent JARDIN a écrit :
Le 20/12/2016 à 15:34, Olivier Dugeon a écrit :
but used the mailing list to send it instead of Pull Request, or good pratice, we shall not commit hidden patches without going thru the mailing list or pull request (both are fine for me), till it has been ack't without any nack. Patchwork would help. Agree; Again, Gerrit could be of a great help. From Martin tests, it is possible to set up gerrit on top of GitHub. It allows a smooth patch review and automatic patch integration.
directly commit.
Your patch is an ack for me, you are welcomed to push. Thanks. But, I'm not authorized to push directly code in the git repo.
Olivier
Le 20/12/2016 à 15:20, Olivier Dugeon a écrit :
Rationalize Link Parameters flags
* lib/if.h: Remove LP_TE as Link Parameters is set if different from 0 See IS_LINK_PARAMS_SET macro and use LP_TE_METRIC to determine if TE metric is set or not * lib/if.c: replace LP_TE by LP_TE_METRIC in default LP status * zebra/interface.c: replace LP_TE by LP_TE_METRIC and check if TE metric is equal to standard metric or not * ospfd/ospf_te.c: replace LP_TE by LP_TE_METRIC * isisd/isis_te.c: replace LP_TE by LP_TE_METRIC
Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com> --- isisd/isis_te.c | 2 +- lib/if.c | 4 ++-- lib/if.h | 9 ++++++--- ospfd/ospf_te.c | 2 +- zebra/interface.c | 8 ++++---- 5 files changed, 14 insertions(+), 11 deletions(-)
ack'd
participants (2)
-
Olivier Dugeon -
Vincent JARDIN