New Defects reported by Coverity Scan for freerangerouting/frr
Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1454535: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_hello.c: 419 in eigrp_sw_version_initialize() ________________________________________________________________________________________________________ *** CID 1454535: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_hello.c: 419 in eigrp_sw_version_initialize() 413 char ver_string[] = VERSION; 414 char *dash = strstr(ver_string, "-"); 415 416 if (dash) 417 dash[0] = '\0'; 418
CID 1454535: Error handling issues (CHECKED_RETURN) Calling "sscanf" without checking return value (as is done elsewhere 37 out of 41 times).
419 sscanf(ver_string, "%d.%d", &FRR_MAJOR, &FRR_MINOR); 420 } 421 422 /** 423 * @fn eigrp_sw_version_encode 424 *
** CID 1454534: Memory - corruptions (OVERRUN) /zebra/zserv.c: 1333 in zread_ipv4_delete() ________________________________________________________________________________________________________ *** CID 1454534: Memory - corruptions (OVERRUN) /zebra/zserv.c: 1333 in zread_ipv4_delete() 1327 * by label, but 1328 * we don't care for delete. 1329 */ 1330 if (CHECK_FLAG(api.message, ZAPI_MESSAGE_LABEL)) 1331 stream_forward_getp(s, 1332 sizeof(u_int32_t));
CID 1454534: Memory - corruptions (OVERRUN) Assigning: "nexthop_p" = "&nexthop". "nexthop_p" now points to byte 0 of "nexthop" (which consists of 4 bytes).
1333 nexthop_p = (union g_addr *)&nexthop; 1334 break; 1335 case NEXTHOP_TYPE_IPV4_IFINDEX: 1336 nexthop.s_addr = stream_get_ipv4(s); 1337 nexthop_p = (union g_addr *)&nexthop; 1338 ifindex = stream_getl(s);
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05... To manage Coverity Scan email notifications for "frr@lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...
participants (1)
-
scan-admin@coverity.com