Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1488737: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1488737: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_nsm.c: 246 in ospf_db_summary_add() 240 241 /* Stay away from any Local Translated Type-7 LSAs */ 242 if (CHECK_FLAG(lsa->flags, OSPF_LSA_LOCAL_XLT)) 243 return 0; 244 245 if (IS_LSA_MAXAGE(lsa))

...

...

CID 1488737: Null pointer dereferences (FORWARD_NULL) Passing "nbr" to "ospf_ls_retransmit_add", which dereferences null "nbr->oi".

246 ospf_ls_retransmit_add(nbr, lsa); 247 else 248 ospf_lsdb_add(&nbr->db_sum, lsa); 249 250 return 0; 251 }

** CID 1488736: Incorrect expression (COPY_PASTE_ERROR) /bgpd/bgp_route.c: 3473 in bgp_update() ________________________________________________________________________________________________________ *** CID 1488736: Incorrect expression (COPY_PASTE_ERROR) /bgpd/bgp_route.c: 3473 in bgp_update() 3467 3468 if (pi->extra && pi->extra->bgp_orig) 3469 bgp_nexthop = pi->extra->bgp_orig; 3470 3471 nh_afi = BGP_ATTR_NH_AFI(afi, pi->attr); 3472

...

...

CID 1488736: Incorrect expression (COPY_PASTE_ERROR) "bgp" in "bgp_find_or_add_nexthop(bgp, bgp_nexthop, nh_afi, pi, NULL, connected)" looks like a copy-paste error.

3473 if (bgp_find_or_add_nexthop(bgp, bgp_nexthop, nh_afi, 3474 pi, NULL, connected) 3475 || CHECK_FLAG(peer->flags, PEER_FLAG_IS_RFAPI_HD)) 3476 bgp_path_info_set_flag(rn, pi, BGP_PATH_VALID); 3477 else { 3478 if (BGP_DEBUG(nht, NHT)) {

________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...