bgpd: Fix AS_PATH size calculation for long paths
Hi, I got caught up with the bug below https://github.com/donaldsharp/frr/commit/084002351fbfd6b4e2d9c4c218288b2324... triggered by the announcement discussed here https://mailman.nanog.org/pipermail/nanog/2017-September/092536.html I see its not been ported to either stable branch. I am guessing its safe to apply the patch as is to both stable 2.0 and 3.0 ? While on this topic is 3.0 considered stable enough to run in production ? Or better to stick with 2.0 ? ---Mike -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/
I'll cherry-pick this bug to 2.0 and 3.0. Shouldn't be an issue at all. I would say 3.0 is more than stable enough. donald On Sun, Oct 1, 2017 at 12:10 PM, Mike Tancsa <mike@sentex.net> wrote:
Hi, I got caught up with the bug below
https://github.com/donaldsharp/frr/commit/084002351fbfd6b4e2d9c4c218288b2324...
triggered by the announcement discussed here
https://mailman.nanog.org/pipermail/nanog/2017-September/092536.html
I see its not been ported to either stable branch. I am guessing its safe to apply the patch as is to both stable 2.0 and 3.0 ?
While on this topic is 3.0 considered stable enough to run in production ? Or better to stick with 2.0 ?
---Mike
-- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/
_______________________________________________ dev mailing list dev@lists.frrouting.org https://lists.frrouting.org/listinfo/dev
On 10/1/2017 3:04 PM, Donald Sharp wrote:
I'll cherry-pick this bug to 2.0 and 3.0. Shouldn't be an issue at all. I would say 3.0 is more than stable enough.
Thanks! There was another bug someone just submitted a patch for around this issue. Not sure if its correct or not or applies or not. https://lists.quagga.net/pipermail/quagga-dev/2017-October/033289.html --- bgp_aspath.c.orig 2017-10-13 10:59:35.924624000 -0400 +++ bgp_aspath.c 2017-10-13 11:02:16.622721000 -0400 @@ -889,8 +889,8 @@ while ((seg->length - written) > AS_SEGMENT_MAX) { assegment_header_put(s, seg->type, AS_SEGMENT_MAX); - assegment_data_put(s, seg->as, AS_SEGMENT_MAX, - use32bit); + assegment_data_put(s, (seg->as+written), + AS_SEGMENT_MAX, use32bit); written += AS_SEGMENT_MAX; bytes += ASSEGMENT_SIZE(AS_SEGMENT_MAX, use32bit); }
participants (2)
-
Donald Sharp -
Mike Tancsa