[cmaster-next] [PATCH] quagga: Convert ldpd to be built by default
(cherry picked from commit a67ce7192143de7de0741af3d0b4f72ee57c7ffd) --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 7e751cd..128300c 100755 --- a/configure.ac +++ b/configure.ac @@ -1157,11 +1157,11 @@ else fi AM_CONDITIONAL(OSPFD, test "x$OSPFD" = "xospfd") -if test "${enable_ldpd}" = "yes";then +if test "${enable_ldpd}" = "no";then + LDPD="" +else LDPD="ldpd" AC_DEFINE(HAVE_LDPD, 1, ldpd) -else - LDPD="" fi AM_CONDITIONAL(LDPD, test "x$LDPD" = "xldpd") -- 2.9.3
I think we should turn ldpd on for master branch by default. donald On Thu, Dec 8, 2016 at 6:22 PM, Donald Sharp <sharpd@cumulusnetworks.com> wrote:
(cherry picked from commit a67ce7192143de7de0741af3d0b4f72ee57c7ffd) --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac index 7e751cd..128300c 100755 --- a/configure.ac +++ b/configure.ac @@ -1157,11 +1157,11 @@ else fi AM_CONDITIONAL(OSPFD, test "x$OSPFD" = "xospfd")
-if test "${enable_ldpd}" = "yes";then +if test "${enable_ldpd}" = "no";then + LDPD="" +else LDPD="ldpd" AC_DEFINE(HAVE_LDPD, 1, ldpd) -else - LDPD="" fi AM_CONDITIONAL(LDPD, test "x$LDPD" = "xldpd")
-- 2.9.3
Hi Donald, Yes for sure. It is mandatory for MP-BGP to manage L3VPN. Regards Olivier Le 09/12/2016 à 00:25, Donald Sharp a écrit :
I think we should turn ldpd on for master branch by default.
donald
On Thu, Dec 8, 2016 at 6:22 PM, Donald Sharp <sharpd@cumulusnetworks.com> wrote:
(cherry picked from commit a67ce7192143de7de0741af3d0b4f72ee57c7ffd) --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac index 7e751cd..128300c 100755 --- a/configure.ac +++ b/configure.ac @@ -1157,11 +1157,11 @@ else fi AM_CONDITIONAL(OSPFD, test "x$OSPFD" = "xospfd")
-if test "${enable_ldpd}" = "yes";then +if test "${enable_ldpd}" = "no";then + LDPD="" +else LDPD="ldpd" AC_DEFINE(HAVE_LDPD, 1, ldpd) -else - LDPD="" fi AM_CONDITIONAL(LDPD, test "x$LDPD" = "xldpd")
-- 2.9.3
_______________________________________________ cmaster-next mailing list cmaster-next@lists.nox.tf https://lists.nox.tf/listinfo/cmaster-next
-- logo Orange <http://www.orange.com> Olivier Dugeon Senior research engineer in QoS and network control Open Source Referent Orange/IMT/OLN/WTC/IEE/OPEN fixe : +33 2 96 07 28 80 mobile : +33 6 82 90 37 85 olivier.dugeon@orange.com <mailto:olivier.dugeon@orange.com>
+1 Le 9 décembre 2016 9:58:19 AM Olivier Dugeon <olivier.dugeon@orange.com> a écrit :
Hi Donald,
Yes for sure. It is mandatory for MP-BGP to manage L3VPN.
Regards
Olivier
Le 09/12/2016 à 00:25, Donald Sharp a écrit :
I think we should turn ldpd on for master branch by default.
donald
On Thu, Dec 8, 2016 at 6:22 PM, Donald Sharp <sharpd@cumulusnetworks.com> wrote:
(cherry picked from commit a67ce7192143de7de0741af3d0b4f72ee57c7ffd) --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac index 7e751cd..128300c 100755 --- a/configure.ac +++ b/configure.ac @@ -1157,11 +1157,11 @@ else fi AM_CONDITIONAL(OSPFD, test "x$OSPFD" = "xospfd")
-if test "${enable_ldpd}" = "yes";then +if test "${enable_ldpd}" = "no";then + LDPD="" +else LDPD="ldpd" AC_DEFINE(HAVE_LDPD, 1, ldpd) -else - LDPD="" fi AM_CONDITIONAL(LDPD, test "x$LDPD" = "xldpd")
-- 2.9.3
_______________________________________________ cmaster-next mailing list cmaster-next@lists.nox.tf https://lists.nox.tf/listinfo/cmaster-next
-- logo Orange <http://www.orange.com>
Olivier Dugeon Senior research engineer in QoS and network control Open Source Referent Orange/IMT/OLN/WTC/IEE/OPEN
fixe : +33 2 96 07 28 80 mobile : +33 6 82 90 37 85 olivier.dugeon@orange.com <mailto:olivier.dugeon@orange.com>
---------- _______________________________________________ cmaster-next mailing list cmaster-next@lists.nox.tf https://lists.nox.tf/listinfo/cmaster-next
On Thu, Dec 8, 2016 at 9:22 PM, Donald Sharp <sharpd@cumulusnetworks.com> wrote:
(cherry picked from commit a67ce7192143de7de0741af3d0b4f72ee57c7ffd) --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac index 7e751cd..128300c 100755 --- a/configure.ac +++ b/configure.ac @@ -1157,11 +1157,11 @@ else fi AM_CONDITIONAL(OSPFD, test "x$OSPFD" = "xospfd")
-if test "${enable_ldpd}" = "yes";then +if test "${enable_ldpd}" = "no";then + LDPD="" +else LDPD="ldpd" AC_DEFINE(HAVE_LDPD, 1, ldpd) -else - LDPD="" fi AM_CONDITIONAL(LDPD, test "x$LDPD" = "xldpd")
Great :) Acked-by: Renato Westphal <renato@opensourcerouting.org> -- Renato Westphal
participants (4)
-
Donald Sharp -
Olivier Dugeon -
Renato Westphal -
Vincent Jardin