Updating internal crypto implementation
FRR has an "internal" implementation of the MD5 and SHA-256 algorithms, including HMAC functions for both. [1] This code is under a BSD license, and provides an alternative to linking FRR against OpenSSL, for which there were historical (?) issues around GPL incompatibility. Several routing protocols use one of these hash algorithms. ospf6d was extended last year to support the OSPFv3 Authentication Trailer (RFC 7166), which may use any of HMAC-SHA-1, HMAC-SHA-256, HMAC-SHA-384, or HMAC-SHA-512. [2] The choice of algorithm is limited unless FRR has been compiled with OpenSSL support. Can we update FRR's internal crypto implementation in order to overcome this limitation? For example: * Gnulib provides a drop-in version of each of the algorithms mentioned above for inclusion in open-source projects, available under LGPL 2.1. * FreeBSD has adapted Colin Percival's SHA-256 implementation to support the other SHA-2 algorithms (but without the HMAC functions - which would seem straightforward to adapt). * Or should FRR rely on an external library for these functions instead? Should it allow the use of something other than OpenSSL, such as Libgcrypt? Thanks in advance, David [1] The SHA-256 implementation was written by Colin Percival, originally for FreeBSD. His current version seems to be here: https://github.com/Tarsnap/libcperciva/blob/master/alg/sha256.c [2] ospf6d also supports the use of HMAC-MD5 here, despite this not being specified in RFC 7166.
Hi David, Add "Is there someone will to do the work and maintain the code?" to the non-library options. The answer to that q. very well could be "no" in which case the library is definitely the way to go. :) Thanks, Chris. "Ward, David - 0665 - MITLL" <david.ward@ll.mit.edu> writes:
FRR has an "internal" implementation of the MD5 and SHA-256 algorithms, including HMAC functions for both. [1] This code is under a BSD license, and provides an alternative to linking FRR against OpenSSL, for which there were historical (?) issues around GPL incompatibility. Several routing protocols use one of these hash algorithms.
ospf6d was extended last year to support the OSPFv3 Authentication Trailer (RFC 7166), which may use any of HMAC-SHA-1, HMAC-SHA-256, HMAC-SHA-384, or HMAC-SHA-512. [2] The choice of algorithm is limited unless FRR has been compiled with OpenSSL support.
Can we update FRR's internal crypto implementation in order to overcome this limitation? For example: * Gnulib provides a drop-in version of each of the algorithms mentioned above for inclusion in open-source projects, available under LGPL 2.1. * FreeBSD has adapted Colin Percival's SHA-256 implementation to support the other SHA-2 algorithms (but without the HMAC functions - which would seem straightforward to adapt). * Or should FRR rely on an external library for these functions instead? Should it allow the use of something other than OpenSSL, such as Libgcrypt?
Thanks in advance,
David
[1] The SHA-256 implementation was written by Colin Percival, originally for FreeBSD. His current version seems to be here: https://github.com/Tarsnap/libcperciva/blob/master/alg/sha256.c
[2] ospf6d also supports the use of HMAC-MD5 here, despite this not being specified in RFC 7166.
_______________________________________________ dev mailing list dev@lists.frrouting.org https://lists.frrouting.org/listinfo/dev
In theory, I am more than happy with having more security options in FRR, especially if some generic functions we are using can be taken out of FRR and the code maintenance can be taken care of by some other library. I guess where I have been hesitating to respond is the sentence `Can we update...`. I am not sure if I should read the sentence as either: a) David Wall is saying I will do the work to update this code b) The we implies that someone should just pick this up from the community and run with the idea. If (a) then I say go for it, David! For this work, though, I would want to see a plan of action for how this is going to be done in the code base. Mainly so that the 2-3 people within the FRR community who really really care about how this is done won't come back and say do it completely differently and your and our time is not wasted. if (b) then I say that's a great idea! Unfortunately due to how open source development is done, until some business has a use case for this expanded functionality, this idea is going to languish. Finally if you are going to do option (a), please feel free to privately send me email( or come talk to us on slack ) and we can get the ball rolling on helping you get the work done. thanks! donald On Thu, Jun 1, 2023 at 6:31 AM Christian Hopps <chopps@chopps.org> wrote:
Hi David,
Add "Is there someone will to do the work and maintain the code?" to the non-library options. The answer to that q. very well could be "no" in which case the library is definitely the way to go. :)
Thanks, Chris.
"Ward, David - 0665 - MITLL" <david.ward@ll.mit.edu> writes:
FRR has an "internal" implementation of the MD5 and SHA-256 algorithms, including HMAC functions for both. [1] This code is under a BSD license, and provides an alternative to linking FRR against OpenSSL, for which there were historical (?) issues around GPL incompatibility. Several routing protocols use one of these hash algorithms.
ospf6d was extended last year to support the OSPFv3 Authentication Trailer (RFC 7166), which may use any of HMAC-SHA-1, HMAC-SHA-256, HMAC-SHA-384, or HMAC-SHA-512. [2] The choice of algorithm is limited unless FRR has been compiled with OpenSSL support.
Can we update FRR's internal crypto implementation in order to overcome this limitation? For example: * Gnulib provides a drop-in version of each of the algorithms mentioned above for inclusion in open-source projects, available under LGPL 2.1. * FreeBSD has adapted Colin Percival's SHA-256 implementation to support the other SHA-2 algorithms (but without the HMAC functions - which would seem straightforward to adapt). * Or should FRR rely on an external library for these functions instead? Should it allow the use of something other than OpenSSL, such as Libgcrypt?
Thanks in advance,
David
[1] The SHA-256 implementation was written by Colin Percival, originally for FreeBSD. His current version seems to be here: https://github.com/Tarsnap/libcperciva/blob/master/alg/sha256.c
[2] ospf6d also supports the use of HMAC-MD5 here, despite this not being specified in RFC 7166.
_______________________________________________ dev mailing list dev@lists.frrouting.org https://lists.frrouting.org/listinfo/dev
_______________________________________________ dev mailing list dev@lists.frrouting.org https://lists.frrouting.org/listinfo/dev
participants (3)
-
Christian Hopps -
Donald Sharp -
Ward, David - 0665 - MITLL