New Defects reported by Coverity Scan for freerangerouting/frr
Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1566150: Null pointer dereferences (NULL_RETURNS) /zebra/interface.c: 1527 in interface_vrf_change() ________________________________________________________________________________________________________ *** CID 1566150: Null pointer dereferences (NULL_RETURNS) /zebra/interface.c: 1527 in interface_vrf_change() 1521 vrf_id_t exist_id; 1522 1523 exist_id = zebra_vrf_lookup_by_table(tableid, ns_id); 1524 if (exist_id != VRF_DEFAULT) { 1525 vrf = vrf_lookup_by_id(exist_id); 1526
CID 1566150: Null pointer dereferences (NULL_RETURNS) Dereferencing "vrf", which is known to be "NULL".
1527 flog_err( 1528 EC_ZEBRA_VRF_MISCONFIGURED, 1529 "VRF %s id %u table id overlaps existing vrf %s(%d), misconfiguration exiting", 1530 name, ifindex, vrf->name, vrf->vrf_id); 1531 exit(-1); 1532 }
** CID 1566149: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1566149: Null pointer dereferences (NULL_RETURNS) /zebra/interface.c: 2288 in zebra_if_dplane_result() 2282 * that we need to handle( create/delete the 2283 * interface as needed ) 2284 */ 2285 if (dp_res == ZEBRA_DPLANE_REQUEST_QUEUED) 2286 zebra_if_dplane_ifp_handling(ctx); 2287 else
CID 1566149: Null pointer dereferences (NULL_RETURNS) Dereferencing a pointer that might be "NULL" "ifp" when calling "zebra_if_update_ctx".
2288 zebra_if_update_ctx(ctx, ifp); 2289 break; 2290 2291 case DPLANE_OP_INTF_NETCONFIG: 2292 zebra_if_netconf_update_ctx(ctx, ifp, ifindex); 2293 break;
** CID 1566148: Control flow issues (DEADCODE) /zebra/interface.c: 1447 in zebra_if_netconf_update_ctx() ________________________________________________________________________________________________________ *** CID 1566148: Control flow issues (DEADCODE) /zebra/interface.c: 1447 in zebra_if_netconf_update_ctx() 1441 linkdown_set = &zrouter.default_linkdownv4; 1442 } else { 1443 mcast_set = &zrouter.default_mc_forwardingv6; 1444 linkdown_set = &zrouter.default_linkdownv6; 1445 } 1446 } else {
CID 1566148: Control flow issues (DEADCODE) Execution cannot reach the expression "NULL" inside this statement: "zif = (ifp ? ifp->info : NU...".
1447 zif = ifp ? ifp->info : NULL; 1448 if (!zif) { 1449 if (IS_ZEBRA_DEBUG_KERNEL) 1450 zlog_debug( 1451 "%s: if %s(%u) zebra info pointer is NULL", 1452 __func__, ifp ? ifp->name : "(null)",
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...
participants (1)
-
scan-admin@coverity.com