New Defects reported by Coverity Scan for freerangerouting/frr
Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1460438: Uninitialized variables (UNINIT) /eigrpd/eigrp_reply.c: 173 in eigrp_reply_receive() ________________________________________________________________________________________________________ *** CID 1460438: Uninitialized variables (UNINIT) /eigrpd/eigrp_reply.c: 173 in eigrp_reply_receive() 167 eigrp->topology_table, &dest_addr); 168 /* 169 * Destination must exists 170 */ 171 if (!dest) { 172 char buf[PREFIX_STRLEN];
CID 1460438: Uninitialized variables (UNINIT) Using uninitialized element of array "buf" when calling "strlen".
173 zlog_err("%s: Received prefix %s which we do not know about", 174 __PRETTY_FUNCTION__, 175 prefix2str(&dest_addr, buf, strlen(buf))); 176 continue; 177 } 178
** CID 1460437: Resource leaks (RESOURCE_LEAK) /eigrpd/eigrp_reply.c: 160 in eigrp_reply_receive() ________________________________________________________________________________________________________ *** CID 1460437: Resource leaks (RESOURCE_LEAK) /eigrpd/eigrp_reply.c: 160 in eigrp_reply_receive() 154 continue; 155 156 struct prefix dest_addr; 157 158 stream_set_getp(s, s->getp - sizeof(u_int16_t)); 159
CID 1460437: Resource leaks (RESOURCE_LEAK) Overwriting "tlv" in "tlv = eigrp_read_ipv4_tlv(s)" leaks the storage that "tlv" points to.
160 tlv = eigrp_read_ipv4_tlv(s); 161 162 dest_addr.family = AF_INET; 163 dest_addr.u.prefix4 = tlv->destination; 164 dest_addr.prefixlen = tlv->prefix_length; 165 struct eigrp_prefix_entry *dest =
** CID 1460436: Control flow issues (DEADCODE) /eigrpd/eigrp_query.c: 240 in eigrp_send_query() ________________________________________________________________________________________________________ *** CID 1460436: Control flow issues (DEADCODE) /eigrpd/eigrp_query.c: 240 in eigrp_send_query() 234 new_packet = true; 235 } 236 } 237 238 if (!has_tlv) { 239 if (ep)
CID 1460436: Control flow issues (DEADCODE) Execution cannot reach this statement: "eigrp_packet_free(ep);".
240 eigrp_packet_free(ep); 241 return; 242 } 243 244 if ((ei->params.auth_type == EIGRP_AUTH_TYPE_MD5) 245 && ei->params.auth_keychain != NULL)
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05... To manage Coverity Scan email notifications for "frr@lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...
participants (1)
-
scan-admin@coverity.com