[cmaster-next] [PATCH] bgpd: Fix crashes when no default bgp instance is configured.
Donald Sharp
sharpd at cumulusnetworks.com
Fri Dec 2 11:20:38 EST 2016
When removing the call into rfapi_vty_out_vncinfo if we are
SAFI_UNICAST we move onto the next issue:
E AssertionError: Routing Table verification failed for
router r1, view 1:
E *** actual BGP routing table
E --- expected BGP routing table
E ***************
E *** 4,40 ****
E Origin codes: i - IGP, e - EGP, ? - incomplete
E
E Network Next Hop Metric
LocPrf Weight Path
E ! 10.0.1.0/24 172.16.1.5
0 65005 i
E ! 172.16.1.2
0 65002 i
E ! 172.16.1.1
0 65001 i
E ! 10.101.0.0/24 172.16.1.1 100
0 65001 i
E ! 10.101.1.0/24 172.16.1.1 100
0 65001 i
E ! 10.101.2.0/24 172.16.1.1 100
0 65001 i
E ! 10.101.3.0/24 172.16.1.1 100
0 65001 i
E ! 10.101.4.0/24 172.16.1.1 100
0 65001 i
E ! 10.101.5.0/24 172.16.1.1 100
0 65001 i
E ! 10.101.6.0/24 172.16.1.1 100
0 65001 i
E ! 10.101.7.0/24 172.16.1.1 100
0 65001 i
E ! 10.101.8.0/24 172.16.1.1 100
0 65001 i
E ! 10.101.9.0/24 172.16.1.1 100
0 65001 i
E ! 10.102.0.0/24 172.16.1.2 100
0 65002 i
E ! 10.102.1.0/24 172.16.1.2 100
0 65002 i
E ! 10.102.2.0/24 172.16.1.2 100
0 65002 i
E ! 10.102.3.0/24 172.16.1.2 100
0 65002 i
E ! 10.102.4.0/24 172.16.1.2 100
0 65002 i
E ! 10.102.5.0/24 172.16.1.2 100
0 65002 i
E ! 10.102.6.0/24 172.16.1.2 100
0 65002 i
E ! 10.102.7.0/24 172.16.1.2 100
0 65002 i
E ! 10.102.8.0/24 172.16.1.2 100
0 65002 i
E ! 10.102.9.0/24 172.16.1.2 100
0 65002 i
E ! 10.105.0.0/24 172.16.1.5 100
0 65005 i
E ! 10.105.1.0/24 172.16.1.5 100
0 65005 i
E ! 10.105.2.0/24 172.16.1.5 100
0 65005 i
E ! 10.105.3.0/24 172.16.1.5 100
0 65005 i
E ! 10.105.4.0/24 172.16.1.5 100
0 65005 i
E ! 10.105.5.0/24 172.16.1.5 100
0 65005 i
E ! 10.105.6.0/24 172.16.1.5 100
0 65005 i
E ! 10.105.7.0/24 172.16.1.5 100
0 65005 i
E ! 10.105.8.0/24 172.16.1.5 100
0 65005 i
E ! 10.105.9.0/24 172.16.1.5 100
0 65005 i
E ! 172.20.0.0/28 0.0.0.0 0
32768 i
E --- 4,40 ----
E Origin codes: i - IGP, e - EGP, ? - incomplete
E
E Network Next Hop Metric
LocPrf Weight Path
E ! * 10.0.1.0/24 172.16.1.5
0 65005 i
E ! * 172.16.1.2
0 65002 i
E ! *> 172.16.1.1
0 65001 i
E ! *> 10.101.0.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.101.1.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.101.2.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.101.3.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.101.4.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.101.5.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.101.6.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.101.7.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.101.8.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.101.9.0/24 172.16.1.1 100
0 65001 i
E ! *> 10.102.0.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.102.1.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.102.2.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.102.3.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.102.4.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.102.5.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.102.6.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.102.7.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.102.8.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.102.9.0/24 172.16.1.2 100
0 65002 i
E ! *> 10.105.0.0/24 172.16.1.5 100
0 65005 i
E ! *> 10.105.1.0/24 172.16.1.5 100
0 65005 i
E ! *> 10.105.2.0/24 172.16.1.5 100
0 65005 i
E ! *> 10.105.3.0/24 172.16.1.5 100
0 65005 i
E ! *> 10.105.4.0/24 172.16.1.5 100
0 65005 i
E ! *> 10.105.5.0/24 172.16.1.5 100
0 65005 i
E ! *> 10.105.6.0/24 172.16.1.5 100
0 65005 i
E ! *> 10.105.7.0/24 172.16.1.5 100
0 65005 i
E ! *> 10.105.8.0/24 172.16.1.5 100
0 65005 i
E ! *> 10.105.9.0/24 172.16.1.5 100
0 65005 i
E ! *> 172.20.0.0/28 0.0.0.0 0
32768 i
E
E assert 1 == 0
bgp_multiview_topo1/test_bgp_multiview_topo1.py:436: AssertionError
=========================== 1 failed, 6 passed in 92.18 seconds
===========================
I'm not sure now how to stop the test to allow me to connect to r1 to
do a little debugging. Martin is this possible?
donald
On Thu, Dec 1, 2016 at 9:10 PM, Donald Sharp <sharpd at cumulusnetworks.com> wrote:
> We've changed the output of the show ip bgp. To always display
> 'type=<route type>, subtype=..' it doubles the output length and
> additionally it probably breaks end user scripts.
>
> Looking at the called function, the extra information presented here
> really belongs in a detailed output instead of a 'show ip bgp' output.
>
> donald
>
> On Thu, Dec 1, 2016 at 8:54 PM, G. Paul Ziemba
> <pz-cmaster-next at ziemba.us> wrote:
>>>On December 1, 2016 9:16:00 AM Donald Sharp <sharpd at cumulusnetworks.com> wrote:
>>>> Additionally I see lots of unguarded debugs in the vnc code. I
>>>> believe these need to be cleaned up as well in some manner, thoughts?
>>
>> I'm coming late to this discussion, sorry. Could you please elaborate
>> on "unguarded"?
>>
>> cheers,
>>
>> ~!paul
>> --
>> G. Paul Ziemba
>> FreeBSD unix:
>> 5:56PM up 102 days, 21:35, 7 users, load averages: 0.83, 0.92, 0.99
>>
>> _______________________________________________
>> cmaster-next mailing list
>> cmaster-next at lists.nox.tf
>> https://lists.nox.tf/listinfo/cmaster-next
More information about the dev
mailing list