[cmaster-next] [PATCH] bgpd: Remove dead function

Donald Sharp sharpd at cumulusnetworks.com
Mon Dec 5 08:24:49 EST 2016


Can we see a patch that adds some header ( or something ) that let's
us know we have an unused function on purpose..  Looking at it I saw
no reason to keep and and have removed it from our internal code base
already.

donald

On Mon, Dec 5, 2016 at 8:21 AM, David Lamparter
<david at opensourcerouting.org> wrote:
> NAK - this was added for the cap'n proto interface to be able to
> auto-find the setter from the struct member name.
>
> If anything, "neighbor XXX activate" should use this...
>
> -David
>
> On Mon, Dec 05, 2016 at 08:02:45AM -0500, Donald Sharp wrote:
>> peer_afc_set is never called.  Remove.
>>
>> Signed-off-by: Donald Sharp <sharpd at cumulusnetworks.com>
>> (cherry picked from commit 1d60d3c12bb66e5db09c06a772ace203bed80cba)
>> ---
>>  bgpd/bgpd.c | 9 ---------
>>  bgpd/bgpd.h | 1 -
>>  2 files changed, 10 deletions(-)
>>
>> diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
>> index 7f92310..dc63550 100644
>> --- a/bgpd/bgpd.c
>> +++ b/bgpd/bgpd.c
>> @@ -1870,15 +1870,6 @@ peer_deactivate (struct peer *peer, afi_t afi, safi_t safi)
>>    return ret;
>>  }
>>
>> -int
>> -peer_afc_set (struct peer *peer, afi_t afi, safi_t safi, int enable)
>> -{
>> -  if (enable)
>> -    return peer_activate (peer, afi, safi);
>> -  else
>> -    return peer_deactivate (peer, afi, safi);
>> -}
>> -
>>  static void
>>  peer_nsf_stop (struct peer *peer)
>>  {
>> diff --git a/bgpd/bgpd.h b/bgpd/bgpd.h
>> index dd6a0fd..4bcbb41 100644
>> --- a/bgpd/bgpd.h
>> +++ b/bgpd/bgpd.h
>> @@ -1265,7 +1265,6 @@ extern int peer_group_listen_range_add(struct peer_group *, struct prefix *);
>>
>>  extern int peer_activate (struct peer *, afi_t, safi_t);
>>  extern int peer_deactivate (struct peer *, afi_t, safi_t);
>> -extern int peer_afc_set (struct peer *, afi_t, safi_t, int);
>>
>>  extern int peer_group_bind (struct bgp *, union sockunion *, struct peer *,
>>                              struct peer_group *, as_t *);
>> --
>> 2.5.5
>>
>>
>> _______________________________________________
>> cmaster-next mailing list
>> cmaster-next at lists.nox.tf
>> https://lists.nox.tf/listinfo/cmaster-next




More information about the dev mailing list