[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1423946:  Null pointer dereferences  (FORWARD_NULL)
/pimd/pimd.c: 202 in pim_instance_terminate()


________________________________________________________________________________________________________
*** CID 1423946:  Null pointer dereferences  (FORWARD_NULL)
/pimd/pimd.c: 202 in pim_instance_terminate()
196       /* Traverse and cleanup rpf_hash */
197       if (pimg && pimg->rpf_hash)
198         {
199           hash_clean (pimg->rpf_hash, (void *) pim_rp_list_hash_clean);
200           hash_free (pimg->rpf_hash);
201         }
>>>     CID 1423946:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "pimg".
202       pim_ssm_terminate (pimg->ssm_info);
203     
204       XFREE (MTYPE_PIM_PIM_INSTANCE, pimg);
205     }
206     
207     static void pim_free()

** CID 1423945:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_ssm.c: 74 in pim_is_grp_standard_ssm()


________________________________________________________________________________________________________
*** CID 1423945:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_ssm.c: 74 in pim_is_grp_standard_ssm()
68     {
69       static int first = 1;
70       static struct prefix group_ssm;
71     
72       if (first)
73         {
>>>     CID 1423945:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "str2prefix" without checking return value (as is done elsewhere 62 out of 76 times).
74           str2prefix (PIM_SSM_STANDARD_RANGE, &group_ssm);
75           first = 0;
76         }
77     
78       return prefix_match (&group_ssm, group);
79     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkfzxdTbB6IM3a99B8NXSty6uSCV1E-2Bu2LFUc3sRJB5I4NKWwoQliD1BEdsNSPybMuUp9cKQCCSXXLXpwJFDbNv2umBRQqHn6-2BV1nYd7t2IkSoKi6B8a94va7NSoAlX50KdoM7ZqwJe09aAFis1znaDpsbtEY2qjXp5Zg94-2F45Zyw-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkfzxdTbB6IM3a99B8NXStydtFFVzfAhZMzSo-2FLis7krPfAu0g2daEDDeaD516XJgFzoxLM6bL20lNZ5y9SNnbZ6ByptNYARwmVatMFbic1VlqJ3zlR6lHv8tZikhXeSF-2Bbvb6f5eXWZiH-2Bq9Hww5hzUj0M7NGBa4zXDqNciUw0XQ-3D-3D