[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1452541:  Null pointer dereferences  (NULL_RETURNS)
/bgpd/bgp_evpn.c: 2761 in bgp_evpn_init()


________________________________________________________________________________________________________
*** CID 1452541:  Null pointer dereferences  (NULL_RETURNS)
/bgpd/bgp_evpn.c: 2761 in bgp_evpn_init()
2755     		hash_create(vni_hash_key_make, vni_hash_cmp, "BGP VNI Hash");
2756     	bgp->import_rt_hash =
2757     		hash_create(import_rt_hash_key_make, import_rt_hash_cmp,
2758     			    "BGP Import RT Hash");
2759     	bf_init(bgp->rd_idspace, UINT16_MAX);
2760     	/*assign 0th index in the bitfield, so that we start with id 1*/
>>>     CID 1452541:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a null pointer "bgp->rd_idspace.data".
2761     	bf_assign_zero_index(bgp->rd_idspace);

** CID 1433360:  Null pointer dereferences  (NULL_RETURNS)
/eigrpd/eigrp_packet.c: 268 in eigrp_make_sha256_digest()


________________________________________________________________________________________________________
*** CID 1433360:  Null pointer dereferences  (NULL_RETURNS)
/eigrpd/eigrp_packet.c: 268 in eigrp_make_sha256_digest()
262     		key = key_lookup_for_send(keychain);
263     
264     	//     saved_len[index] = strnzcpyn(saved_key[index], key,
265     	//                             PLAINTEXT_LENGTH + 1);
266     
267     	source_ip = calloc(16, sizeof(char));
>>>     CID 1433360:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be null "source_ip" when calling "inet_ntop".
268     	inet_ntop(AF_INET, &ei->address->u.prefix4, source_ip, 16);
269     
270     	memset(&ctx, 0, sizeof(ctx));
271     	buffer[0] = '\n';
272     	memcpy(buffer + 1, key, strlen(key->string));
273     	memcpy(buffer + 1 + strlen(key->string), source_ip, strlen(source_ip));

** CID 1399484:  Null pointer dereferences  (NULL_RETURNS)
/tools/permutations.c: 39 in main()


________________________________________________________________________________________________________
*** CID 1399484:  Null pointer dereferences  (NULL_RETURNS)
/tools/permutations.c: 39 in main()
33     {
34     	if (argc < 2) {
35     		fprintf(stdout, USAGE "\n");
36     		exit(EXIT_SUCCESS);
37     	}
38     	struct cmd_element *cmd = calloc(1, sizeof(struct cmd_element));
>>>     CID 1399484:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a null pointer "cmd".
39     	cmd->string = strdup(argv[1]);
40     
41     	struct graph *graph = graph_new();
42     	struct cmd_token *token =
43     		cmd_token_new(START_TKN, cmd->attr, NULL, NULL);
44     	graph_new_node(graph, token, NULL);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkgpe-2B2paXB8zFNLPPM3m3l5NBJafYAJzv0Lw-2BPV-2FNzJQVkkm-2BmtDRqGRBpP5hzNFjmC4-2F6KHw5K1J05TTtE9F7FRCQcv87PUMlwmW-2B44Z5v9-2B776tgI-2BEXn34E3hd5-2Bf81UjG9zPXU-2FKL1xb6UbdOAaK7JwASfGLES1BS5g5oHIQ-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkgpe-2B2paXB8zFNLPPM3m3lBrlGxoGpNYZ2bV8snfthcOWFTuInkJlST9bXsS-2Fnk9laY4KY2oyZUd-2BqpNU-2B6bdEXXqD2yXO2UUiOOqecxcOLv9ffma-2FW5tUwxpGpGvNQpTohSdNTNcHW6dov39RbnjufQDTvB8dDlyGvxmcU9lB5A-3D-3D