[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
76 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1454848:  Error handling issues  (CHECKED_RETURN)
/eigrpd/eigrp_vty.c: 397 in eigrp_network()


________________________________________________________________________________________________________
*** CID 1454848:  Error handling issues  (CHECKED_RETURN)
/eigrpd/eigrp_vty.c: 397 in eigrp_network()
391            "EIGRP network prefix\n")
392     {
393     	VTY_DECLVAR_CONTEXT(eigrp, eigrp);
394     	struct prefix p;
395     	int ret;
396     
>>>     CID 1454848:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "str2prefix" without checking return value (as is done elsewhere 66 out of 80 times).
397     	str2prefix(argv[1]->arg, &p);
398     
399     	ret = eigrp_network_set(eigrp, &p);
400     
401     	if (ret == 0) {
402     		vty_out(vty, "There is already same network statement.\n");

** CID 1454847:  Error handling issues  (CHECKED_RETURN)
/eigrpd/eigrp_vty.c: 420 in no_eigrp_network()


________________________________________________________________________________________________________
*** CID 1454847:  Error handling issues  (CHECKED_RETURN)
/eigrpd/eigrp_vty.c: 420 in no_eigrp_network()
414            "EIGRP network prefix\n")
415     {
416     	VTY_DECLVAR_CONTEXT(eigrp, eigrp);
417     	struct prefix p;
418     	int ret;
419     
>>>     CID 1454847:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "str2prefix" without checking return value (as is done elsewhere 66 out of 80 times).
420     	str2prefix(argv[2]->arg, &p);
421     
422     	ret = eigrp_network_unset(eigrp, &p);
423     
424     	if (ret == 0) {
425     		vty_out(vty, "Can't find specified network configuration.\n");


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJknZNibRk5i3aIq4eE6p80DSEsh48AEFCWr2tXsARKdvckmepqWRoCYKtw9PWTz6Zh3IduoCGh7f7ADp6f6LO9lqFXzhQ0qTadVceF-2F2qkztxhL5fa6iFrwx8Ci1MaxSPQTUg0RwcgaKeLNrXWQ-2FZj7XY8GKb2bbU07cIdQ8Di6Kg-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJknZNibRk5i3aIq4eE6p80DyVeN2aapd4pBl-2FPjiO9SgKy0xU8a0t1t7HIBkY8qOGelb-2BYRRzuIuurg5P5ozGnaBvdWsx-2B-2FBG-2FGPaz1ttMSWzobYjvDBmV6CbRhdCqkNhBjbKBikAaObbPNM20P2nQq-2BRwZHKxBnzdj-2F1ubvQxk4Q-3D-3D