[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1462351:  Program hangs  (LOCK)
/bgpd/bgp_io.c: 348 in bgp_process_reads()


________________________________________________________________________________________________________
*** CID 1462351:  Program hangs  (LOCK)
/bgpd/bgp_io.c: 348 in bgp_process_reads()
342     				&peer->t_read);
343     		if (added_pkt)
344     			thread_add_timer_msec(bm->master, bgp_process_packet,
345     					      peer, 0, &peer->t_process_packet);
346     	}
347     
>>>     CID 1462351:  Program hangs  (LOCK)
>>>     Returning without unlocking "peer->io_mtx".
348     	return 0;
349     }
350     
351     /**
352      * Flush peer output buffer.
353      *

** CID 1462350:  Program hangs  (LOCK)
/bgpd/bgp_packet.c: 2286 in bgp_process_packet()


________________________________________________________________________________________________________
*** CID 1462350:  Program hangs  (LOCK)
/bgpd/bgp_packet.c: 2286 in bgp_process_packet()
2280     					bm->master, bgp_process_packet, peer, 0,
2281     					&peer->t_process_packet);
2282     		}
2283     		pthread_mutex_unlock(&peer->io_mtx);
2284     	}
2285     
>>>     CID 1462350:  Program hangs  (LOCK)
>>>     Returning without unlocking "peer->io_mtx".
2286     	return 0;

** CID 1462349:  Program hangs  (LOCK)
/bgpd/bgp_packet.c: 560 in bgp_write_notify()


________________________________________________________________________________________________________
*** CID 1462349:  Program hangs  (LOCK)
/bgpd/bgp_packet.c: 560 in bgp_write_notify()
554     
555     	pthread_mutex_lock(&peer->io_mtx);
556     	{
557     		/* There should be at least one packet. */
558     		s = stream_fifo_pop(peer->obuf);
559     		if (!s)
>>>     CID 1462349:  Program hangs  (LOCK)
>>>     Returning without unlocking "peer->io_mtx".
560     			return 0;
561     		assert(stream_get_endp(s) >= BGP_HEADER_SIZE);
562     	}
563     	pthread_mutex_unlock(&peer->io_mtx);
564     
565     	/* Stop collecting data within the socket */


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJnELSeyHVGWZT1fgTr-2FrmPa9FhZdQ2NSJqz4qojmAyWTiWZCDJJqayWCx98aVXcMpf3XLa0XgJ3xgaSL3rRbbYixcSovSdFPWQnr1DrJwNTe04BYp-2BuU4Zeicf2Bm2tApRbddLJi317e0CU60APEJxmS3mQOOqubvDF6I72j03Sfg-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJnELSeyHVGWZT1fgTr-2FrmPaR7sEkgNs8twQWbpwfv-2BfQ9HSIQm-2Fe2oE1DkHKcO17e2-2BwcErRgF-2FwY9Oq-2FLQ0O4fx6zK3cA8yBYvTh5ju8DjUhYVGezIi2J9OxdkDtSLnXnzAky7K5WFdp1ciLKCpHws-2FeO2aH2kdeTSh79lkuwMoQ-3D-3D