[frr] changing address-family vpn&encap config

[Lou Berger]

Hi Philippe,


On 1/12/2017 8:46 AM, Philippe Guibert wrote:
> Hi all, hi Lou,
>
> I think this makes sense to use the new address-family definition for
> configuration.
>
> About configuration, this may lead to problems.
> Is it possible to have a compilation flag in order to maintain old
> style too ? ( like you demonstrated it for show commands ?).
>
I think reading is trivial and should be supported for now as the
default.  Output is clearly possible, but I'm concerned about the code
complexity & rot for a corner case.

> - That means that further developments will need to rely on this format.
yes.
> ( evpn will become l2vpn evpn ).
I think we should stick to the afi/safi's used in bgp - wherever that
leads us ;-)

> - Also on the issue mentioned, there are some bgp related commits, but
> I don't see vtysh changes.
> And there will be vtysh related changes.

I think the existing change set should be picked up by the pl script. 
Certainly correct if we change address-family...

Lou

>
> Regards,
>
> Philippe
>
> On Thu, Jan 12, 2017 at 2:37 PM, Lou Berger <lberger at labn.net
> <mailto:lberger at labn.net>> wrote:
>
>     Hi all,
>
>     this is related to cleaning up the confusion of treating the vpn
>     safi as
>     afi+safi, see https://github.com/freerangerouting/frr/issues/61
>     <https://github.com/freerangerouting/frr/issues/61>.
>
>     Does anyone object to the following change to *config* in
>     *stable/2.0* -
>     note this will break backwards compatibility (reading old will be
>     preserved, but output will only be new)
>
>     OLD
>
>       address-family ipv4
>       address-family ipv4 (unicast|multicast)
>       address-family ipv6
>       address-family ipv6 (unicast|multicast)
>       address-family vpnv4
>       address-family vpnv4 unicast
>       address-family vpnv6
>       address-family vpnv6 unicast
>       address-family encap
>       address-family encapv4
>       address-family encapv6
>
>     new
>
>       address-family <ipv4|ipv6> [<unicast|multicast|vpn|encap>] //default
>     is unicast
>
>     Lou
>
>
>     _______________________________________________
>     frr mailing list
>     frr at lists.nox.tf <mailto:frr at lists.nox.tf>
>     https://lists.nox.tf/listinfo/frr <https://lists.nox.tf/listinfo/frr>
>
>