[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1446185:  Null pointer dereferences  (NULL_RETURNS)
/ldpd/lde.c: 1345 in lde_nbr_addr_update()


________________________________________________________________________________________________________
*** CID 1446185:  Null pointer dereferences  (NULL_RETURNS)
/ldpd/lde.c: 1345 in lde_nbr_addr_update()
1339     				continue;
1340     			break;
1341     		default:
1342     			continue;
1343     		}
1344     
>>>     CID 1446185:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a null pointer "fn".
1345     		LIST_FOREACH(fnh, &fn->nexthops, entry) {
1346     			if (ldp_addrcmp(fnh->af, &fnh->nexthop,
1347     			    &lde_addr->addr))
1348     				continue;
1349     
1350     			if (removed) {

** CID 1446184:  Incorrect expression  (COPY_PASTE_ERROR)
/lib/openbsd-tree.c: 355 in rbe_remove()


________________________________________________________________________________________________________
*** CID 1446184:  Incorrect expression  (COPY_PASTE_ERROR)
/lib/openbsd-tree.c: 355 in rbe_remove()
349     		if (tmp != NULL) {
350     			if (RBE_LEFT(tmp) == old)
351     				RBE_LEFT(tmp) = rbe;
352     			else
353     				RBE_RIGHT(tmp) = rbe;
354     
>>>     CID 1446184:  Incorrect expression  (COPY_PASTE_ERROR)
>>>     "parent" in "rbe_if_augment(t, parent)" looks like a copy-paste error.
355     			rbe_if_augment(t, parent);
356     		} else
357     			RBH_ROOT(rbt) = rbe;
358     
359     		RBE_PARENT(RBE_LEFT(old)) = rbe;
360     		if (RBE_RIGHT(old))


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmalZNlgNJzHYJsSFHJ8No0ykXuh1FUH1Ypy3xkl-2Fyh-2FEihIcA84pPXxhM9ZxkTWVHVSA5B-2FWggDX-2FdIfA-2BS1bQVepQBeXl3nkHIBepTx-2Fzd9qe-2FrCQqCdP7D-2B-2FsqocN2p2Cfv9Cs9RExAY66Jxsjs3eY1wi9fb8y6u9HarbKnSaQ-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmalZNlgNJzHYJsSFHJ8No09L0R-2BAT8HMXxJ5zZoe4InDcYTYIFllGKUT5VYnakWSBu3ECzIAv0V0rPzWpDTLKlX5cuuDPKBQzaF1KL6g1dO9c-2BjGFrCBtHZSr5vl9s-2FCNNy1hsvnrd64Gh7-2BEBj8G2pvtKsEwcb5oA5AIlBl5-2FqQ-3D-3D