[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1448581:  Error handling issues  (CHECKED_RETURN)
/ospfd/ospf_vty.c: 7094 in no_ip_ospf_area()


________________________________________________________________________________________________________
*** CID 1448581:  Error handling issues  (CHECKED_RETURN)
/ospfd/ospf_vty.c: 7094 in no_ip_ospf_area()
7088         return CMD_SUCCESS;
7089     
7090       argv_find (argv, argc, "area", &idx);
7091     
7092       // Check if we have an address arg and proccess it
7093       if (argc == idx + 3) {
>>>     CID 1448581:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "inet_aton" without checking return value (as is done elsewhere 78 out of 81 times).
7094         inet_aton(argv[idx+2]->arg, &addr);
7095         params = ospf_lookup_if_params (ifp, addr);
7096         if ((params) == NULL)
7097           return CMD_SUCCESS;
7098       }
7099       else

** CID 1448580:  Error handling issues  (CHECKED_RETURN)
/ospfd/ospf_vty.c: 7034 in ip_ospf_area()


________________________________________________________________________________________________________
*** CID 1448580:  Error handling issues  (CHECKED_RETURN)
/ospfd/ospf_vty.c: 7034 in ip_ospf_area()
7028                    VTY_NEWLINE);
7029           return CMD_WARNING;
7030         }
7031     
7032       // Check if we have an address arg and proccess it
7033       if (argc == idx + 3) {
>>>     CID 1448580:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "inet_aton" without checking return value (as is done elsewhere 78 out of 81 times).
7034         inet_aton(argv[idx+2]->arg, &addr);
7035         // update/create address-level params
7036         params = ospf_get_if_params ((ifp), (addr));
7037         if (OSPF_IF_PARAM_CONFIGURED(params, if_area))
7038           {
7039     	vty_out (vty,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJk7XrxND0i6hlJOYgS0-2BSqJ2K08-2BBs-2BR4aQ4Kqlr-2Bdpn7ny0v1UwvdQ9McgHQF7IdZ2N5RGK2fPEP0-2FiTMfMTYcQzhJpU4Dh7itp6JKftpxSfVxBAnr9sVEU-2F0jXTGmVFcAjU2acX0AYAc1zHs1JGmzy0kSvc5h-2FXZJaalHB-2F4AYw-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJk7XrxND0i6hlJOYgS0-2BSqJyVzzYJyrNON0lKdaHQqgtnxzzfSYauYXJAVV8MOybQxbZMkr7nGkZHzIatrRCz4oEzkl9wsdpuRSbErjfCRFh5AFdHKqnz1dJMvVMz1s7Zr6Zxy-2BeoSCMTcZZfHOPHUtNJKGRhPOGe5p2YT9nz4qew-3D-3D