[frr] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1420923:  Null pointer dereferences  (REVERSE_INULL)
/pimd/pim_msg.c: 112 in pim_msg_get_jp_group_size()


________________________________________________________________________________________________________
*** CID 1420923:  Null pointer dereferences  (REVERSE_INULL)
/pimd/pim_msg.c: 112 in pim_msg_get_jp_group_size()
106     
107       size += sizeof (struct pim_encoded_group_ipv4);
108       size += 4;  // Joined sources (2) + Pruned Sources (2)
109     
110       size += sizeof (struct pim_encoded_source_ipv4) * sources->count;
111     
>>>     CID 1420923:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "sources" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
112       js = listgetdata(listhead(sources));
113       if (js && js->up->sg.src.s_addr == INADDR_ANY)
114         {
115           struct pim_upstream *child, *up;
116           struct listnode *up_node;
117     

** CID 742780:  Memory - corruptions  (ARRAY_VS_SINGLETON)
/ospf6d/ospf6_route.c: 948 in ospf6_route_match_head()


________________________________________________________________________________________________________
*** CID 742780:  Memory - corruptions  (ARRAY_VS_SINGLETON)
/ospf6d/ospf6_route.c: 948 in ospf6_route_match_head()
942       struct ospf6_route *route;
943     
944       /* Walk down tree. */
945       node = table->table->top;
946       while (node && node->p.prefixlen < prefix->prefixlen &&
947     	 prefix_match (&node->p, prefix))
>>>     CID 742780:  Memory - corruptions  (ARRAY_VS_SINGLETON)
>>>     Taking address with "&prefix->u.prefix" yields a singleton pointer.
948         node = node->link[prefix_bit(&prefix->u.prefix, node->p.prefixlen)];
949     
950       if (node)
951         route_lock_node (node);
952       while (node && node->info == NULL)
953         node = route_next (node);

** CID 742779:  Memory - corruptions  (ARRAY_VS_SINGLETON)
/ospf6d/ospf6_lsdb.c: 252 in ospf6_lsdb_lookup_next()


________________________________________________________________________________________________________
*** CID 742779:  Memory - corruptions  (ARRAY_VS_SINGLETON)
/ospf6d/ospf6_lsdb.c: 252 in ospf6_lsdb_lookup_next()
246       node = lsdb->table->top;
247       /* walk down tree. */
248       while (node && node->p.prefixlen <= p->prefixlen &&
249              prefix_match (&node->p, p))
250         {
251           matched = node;
>>>     CID 742779:  Memory - corruptions  (ARRAY_VS_SINGLETON)
>>>     Taking address with "&p->u.prefix" yields a singleton pointer.
252           node = node->link[prefix_bit(&p->u.prefix, node->p.prefixlen)];
253         }
254     
255       if (matched)
256         node = matched;
257       else


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkh1DFhcsIuF0qpzeFrxSz6Vpu9bwF7tbkJIo-2FOcMQFNqdCeGmR6FYCnMewcze4zB-2B9DsdnxSPSsoERj8-2Bz06-2Br3-2B9kJj-2F7vAw-2FVF2VUdqRFCdTyKpuqjYQmbUcNVN8725MhvPY8ed1RrOhqKLQGqU5obGqmiQkKb04iyqgiipFZA-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkh1DFhcsIuF0qpzeFrxSz6ZjFqVlb0DvN37vE4GgeovrRE9uOV-2BSB-2BstOW1P5kZS8SHTpKHLxV3jU67ONPEHbpcLmVFZ-2Fk7jWP-2F0F2Wvbypv3ieSKAudXNoL1BaOot7FcNnnQk3UWtbvuW0g8Kaj7XkUDbUaG42bGQhBl4EujU2g-3D-3D