[dev] Proposal to change CLI syntax of 'show ip rib <u_addr> to 'show ip pim rib <u_addr>

[Quentin Young]

show ip [pim] rib?

On May 2, 2017 2:45 PM, "Donald Sharp" <sharpd at cumulusnetworks.com> wrote:

> Yeah I object.  People are used to `show ip rib...` and probably have
> automation towards that.  What is your plan for going forward?
>
> On Tue, May 2, 2017 at 2:34 PM, Chirag Shah <chirag at cumulusnetworks.com>
> wrote:
> > Hi All,
> >
> > If there is no objection I can modify the syntex to have pim as keyword
> and
> > make nexthop with ECMP aware.
> >
> > Thanks & Regards,
> > Chirag Shah
> >
> >
> > On Tue, Apr 4, 2017 at 2:53 PM, Chirag Shah <chirag at cumulusnetworks.com>
> > wrote:
> >>
> >> Hello All,
> >>
> >> The CLI command 'show ip rib <unicast addr> is in pim_cmd.c which
> invokes
> >> zebra lookup for nexthops and return the first available path to user.
> >>
> >> Ideally the command is for PIMd (Zebra Client for nexthop info).
> >>
> >> I would like to propose to change to CLI to specific to PIMd  'show ip
> pim
> >> rib <uincat addr>  rather generic than "ip rib" term.
> >>
> >> Please share your opinion.
> >>
> >>
> >> Kind Regards,
> >> Chirag Shah
> >>
> >> P.S. :
> >>
> >> Cli implementation from pim_cli.c
> >>
> >> DEFUN (show_ip_rib,
> >>        show_ip_rib_cmd,
> >>        "show ip rib A.B.C.D",
> >>        SHOW_STR
> >>        IP_STR
> >>        RIB_STR
> >>        "Unicast address\n")
> >> {
> >>   struct in_addr addr;
> >>   const char *addr_str;
> >>   struct pim_nexthop nexthop;
> >>   char nexthop_addr_str[PREFIX_STRLEN];
> >>   int result;
> >>
> >>   memset (&nexthop, 0, sizeof (nexthop));
> >>   addr_str = argv[0];
> >>   result = inet_pton(AF_INET, addr_str, &addr);
> >>   if (result <= 0) {
> >>     vty_out(vty, "Bad unicast address %s: errno=%d: %s%s",
> >>             addr_str, errno, safe_strerror(errno), VTY_NEWLINE);
> >>     return CMD_WARNING;
> >>   }
> >>
> >>   if (pim_nexthop_lookup(&nexthop, addr, 0)) {
> >>     vty_out(vty, "Failure querying RIB nexthop for unicast address
> %s%s",
> >>             addr_str, VTY_NEWLINE);
> >>     return CMD_WARNING;
> >>   }
> >>
> >>   vty_out(vty, "Address         NextHop         Interface Metric
> >> Preference%s",
> >>           VTY_NEWLINE);
> >>
> >>   pim_addr_dump("<nexthop?>", &nexthop.mrib_nexthop_addr,
> >>                 nexthop_addr_str, sizeof(nexthop_addr_str));
> >>
> >>   vty_out(vty, "%-15s %-15s %-9s %6d %10d%s",
> >>           addr_str,
> >>           nexthop_addr_str,
> >>           nexthop.interface ? nexthop.interface->name : "<ifname?>",
> >>           nexthop.mrib_route_metric,
> >>           nexthop.mrib_metric_preference,
> >>           VTY_NEWLINE);
> >>
> >>   return CMD_SUCCESS;
> >> }
> >>
> >
> >
> > _______________________________________________
> > dev mailing list
> > dev at lists.frrouting.org
> > https://lists.frrouting.org/listinfo/dev
> >
>
> _______________________________________________
> dev mailing list
> dev at lists.frrouting.org
> https://lists.frrouting.org/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.frrouting.org/pipermail/dev/attachments/20170502/b838a607/attachment.html>