[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
10 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1438075:  Program hangs  (ORDER_REVERSAL)
/lib/thread.c: 936 in thread_cancel()


________________________________________________________________________________________________________
*** CID 1438075:  Program hangs  (ORDER_REVERSAL)
/lib/thread.c: 936 in thread_cancel()
930     {
931       struct thread_list *list = NULL;
932       struct pqueue *queue = NULL;
933       struct thread **thread_array = NULL;
934     
935       pthread_mutex_lock (&thread->mtx);
>>>     CID 1438075:  Program hangs  (ORDER_REVERSAL)
>>>     Calling "pthread_mutex_lock" acquires lock "thread_master.mtx" while holding lock "thread.mtx" (count: 1 / 5).
936       pthread_mutex_lock (&thread->master->mtx);
937     
938       assert (pthread_self() == thread->master->owner);
939     
940       switch (thread->type)
941         {

** CID 1438074:  Control flow issues  (DEADCODE)
/pimd/pim_cmd.c: 5950 in ip_pim_bfd()


________________________________________________________________________________________________________
*** CID 1438074:  Control flow issues  (DEADCODE)
/pimd/pim_cmd.c: 5950 in ip_pim_bfd()
5944     {
5945       VTY_DECLVAR_CONTEXT(interface, ifp);
5946       struct pim_interface *pim_ifp = NULL;
5947       struct bfd_info *bfd_info = NULL;
5948     
5949       if (!ifp)
>>>     CID 1438074:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "return 0;".
5950         return CMD_SUCCESS;
5951       pim_ifp = ifp->info;
5952       if (!pim_ifp)
5953         return CMD_SUCCESS;
5954       bfd_info = pim_ifp->bfd_info;
5955     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkCEvVERQkSXhuPhq4WpPTZGKQyca-2BWq-2FRavVGHzbOpptEZkU14apDKCf6zIPqAMhWUOWKH8LSVgfjbBfyKU14oKT5GToZ5m8NH4rUjFGTImZUKIOTzHYjMxny2B0VFoU-2FcMprvMZMYdUS-2FwRF7YWMtiG1t5Wrq5mHx9Avcqxtjbw-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkCEvVERQkSXhuPhq4WpPTZ87HCA8dRP8A6JH7PgCmDhCzwz7FhZXJwbS5IGJmroSqhsb79n8lTzQ06v1VWhhj5lgW6mdK0EF-2F1qEPe-2BjTOwfwjS3Y7gsWYBy434wEy1tccUO2wl3xZW7C48FT-2Fksn1ZECpW0E473cH2XDSM1PxeQ-3D-3D