[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1461144:  Memory - illegal accesses  (BUFFER_SIZE_WARNING)
/ospfd/ospf_vty.c: 4162 in show_ip_ospf_neighbor_sub()


________________________________________________________________________________________________________
*** CID 1461144:  Memory - illegal accesses  (BUFFER_SIZE_WARNING)
/ospfd/ospf_vty.c: 4162 in show_ip_ospf_neighbor_sub()
4156     
4157     				if (nbr->state == NSM_Attempt &&
4158     				    nbr->router_id.s_addr == 0)
4159     					strncpy(neigh_str, "neighbor",
4160     						INET_ADDRSTRLEN);
4161     				else
>>>     CID 1461144:  Memory - illegal accesses  (BUFFER_SIZE_WARNING)
>>>     Calling strncpy with a maximum size argument of 16 bytes on destination array "neigh_str" of size 16 bytes might leave the destination string unterminated.
4162     					strncpy(neigh_str,
4163     						inet_ntoa(nbr->router_id),
4164     						INET_ADDRSTRLEN);
4165     
4166     				json_object_object_get_ex(json, neigh_str,
4167     							  &json_neigh_array);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlzjZlcjiBfSIlxcUaaIwhlAw6yJ6uL9uKC4AyNBLJp9-2FArsjJsv4q1fk5CWmSjSNzjnXzEw6EnMXNXOanPCQfT-2FCQJ4IM-2BD0eoH5Madb3ZeopS9YCPtRwT0hlK6XP-2Fhz1vhgQJT2QU9db0-2F-2FbnDhIfONsBiPZ0fQEOZeljLR-2F8vw-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlzjZlcjiBfSIlxcUaaIwhl71KXKEcN1124E-2FGGOu4VSOwEYhBWcxKwssvDCyGrmrBly7-2F2WAzKD85SqJEzdl1e7waACM-2BjB-2B-2FCIlaxlYT1IKeMoLLq9nkrGnjLsEdgKJJWfBxHH2mPIrkUR4pX-2Bdb6nXGt24FUWXK9Ki1lBpVJpA-3D-3D