[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1457320:  Error handling issues  (NEGATIVE_RETURNS)
/ldpd/ldpd.c: 453 in start_child()


________________________________________________________________________________________________________
*** CID 1457320:  Error handling issues  (NEGATIVE_RETURNS)
/ldpd/ldpd.c: 453 in start_child()
447     		close(fd_async);
448     		close(fd_sync);
449     		return (pid);
450     	}
451     
452     	nullfd = open("/dev/null", O_RDONLY | O_NOCTTY);
>>>     CID 1457320:  Error handling issues  (NEGATIVE_RETURNS)
>>>     "nullfd" is passed to a parameter that cannot be negative.
453     	dup2(nullfd, 0);
454     	dup2(nullfd, 1);
455     	dup2(nullfd, 2);
456     	close(nullfd);
457     
458     	if (dup2(fd_async, LDPD_FD_ASYNC) == -1)


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmb2J4XycPbK64a9R-2BQ2GFcQPGCCbKtG1VSdUcl4nY3wsrcv7ZgQF-2B9As8gGm9ApGsJN2ZDzqsSBm28S4F3rqpjASnJNXeX8jo6CHcF4C6Mm9PvPJmizlKdd0X2RKOTHEkJI-2B-2Bn-2FOVthj6yRdvEwlyniApdmS-2BUnUhEtW9cFlEzXA-3D-3D

To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmb2J4XycPbK64a9R-2BQ2GFcikCpjTsg04elB1KxREG4-2FRj86fPri-2BlZDjW-2Bqy97UZHZpzsa8t-2B8TYvBkQoP95DuNzeZghpeQambg9znmKBjpF3TP6pk9ppabYpiXcBYGMV-2B6p3pu21KmmLX08N277g6LB6WpenPoySWQ6K6v4oM4w-3D-3D