[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1468416:  Error handling issues  (CHECKED_RETURN)
/bgpd/bgp_rd.c: 213 in form_auto_rd()


________________________________________________________________________________________________________
*** CID 1468416:  Error handling issues  (CHECKED_RETURN)
/bgpd/bgp_rd.c: 213 in form_auto_rd()
207     {
208     	char buf[100];
209     
210     	prd->family = AF_UNSPEC;
211     	prd->prefixlen = 64;
212     	sprintf(buf, "%s:%hu", inet_ntoa(router_id), rd_id);
>>>     CID 1468416:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "str2prefix_rd" without checking return value (as is done elsewhere 15 out of 16 times).
213     	str2prefix_rd(buf, prd);

** CID 1468415:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1468415:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_vty_clippy.c: 361 in af_route_map_vpn_imexport()
355     	}
356     #if 0 /* anything that can fail? */
357     	if (_failcnt)
358     		return CMD_WARNING;
359     #endif
360     #endif
>>>     CID 1468415:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "rmap_str" to "af_route_map_vpn_imexport_magic", which dereferences it.
361     	return af_route_map_vpn_imexport_magic(self, vty, argc, argv, no, direction_str, rmap_str);
362     }
363     
364     /* af_import_vrf_route_map => "[no] import vrf route-map RMAP$rmap_str" */
365     DEFUN_CMD_FUNC_DECL(af_import_vrf_route_map)
366     #define funcdecl_af_import_vrf_route_map static int af_import_vrf_route_map_magic(\

** CID 1468414:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1468414:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_vty_clippy.c: 409 in af_import_vrf_route_map()
403     	}
404     #if 0 /* anything that can fail? */
405     	if (_failcnt)
406     		return CMD_WARNING;
407     #endif
408     #endif
>>>     CID 1468414:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "rmap_str" to "af_import_vrf_route_map_magic", which dereferences it.
409     	return af_import_vrf_route_map_magic(self, vty, argc, argv, no, rmap_str);
410     }
411     
412     /* bgp_imexport_vrf => "[no] import vrf NAME$import_name" */
413     DEFUN_CMD_FUNC_DECL(bgp_imexport_vrf)
414     #define funcdecl_bgp_imexport_vrf static int bgp_imexport_vrf_magic(\

** CID 1468413:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1468413:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_vty_clippy.c: 457 in bgp_imexport_vrf()
451     	}
452     #if 0 /* anything that can fail? */
453     	if (_failcnt)
454     		return CMD_WARNING;
455     #endif
456     #endif
>>>     CID 1468413:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "import_name" to "bgp_imexport_vrf_magic", which dereferences it.
457     	return bgp_imexport_vrf_magic(self, vty, argc, argv, no, import_name);
458     }
459     
460     /* bgp_imexport_vpn => "[no] <import|export>$direction_str vpn" */
461     DEFUN_CMD_FUNC_DECL(bgp_imexport_vpn)
462     #define funcdecl_bgp_imexport_vpn static int bgp_imexport_vpn_magic(\

** CID 1465490:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_igmp_mtrace.c: 817 in igmp_mtrace_recv_qry_req()


________________________________________________________________________________________________________
*** CID 1465490:  Error handling issues  (CHECKED_RETURN)
/pimd/pim_igmp_mtrace.c: 817 in igmp_mtrace_recv_qry_req()
811     		}
812     		/*
813     		 * 6.4 Forwarding Traceroute Requests:
814     		 * Previous-hop router not known,
815     		 * packet is sent to an appropriate multicast address
816     		 */
>>>     CID 1465490:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "inet_aton" without checking return value (as is done elsewhere 115 out of 117 times).
817     		inet_aton(MCAST_ALL_ROUTERS, &nh_addr);
818     	}
819     
820     	/* 6.2.2 8. If this router is the Rendez-vous Point */
821     	if (pim_rp_i_am_rp(pim, mtracep->grp_addr)) {
822     		mtrace_rsp_set_fwd_code(rspp, MTRACE_FWD_CODE_REACHED_RP);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJmTQNXHzb1db7ItJJWwEiH8leskqGR3XCgKbc2KopwDIDE1sBH7HhJoxfeDPl0RDuBesIQiwigTUMPj0jg7z25ibB9dWtEaX4EP-2BgeTRYHFdDiI5Fs99Sm0w10vhDVmjRVzKMJqb9RYVEXzkGW09MoqfE6hA4UHmKEvqp-2Bd5-2B8LNg-3D-3D