[dev] 4.0 branch pull

Thu Jan 11 13:55:38 EST 2018

Hi Donald, all,

Things are evolving in the good way as I solve all my bugs, except the initial condition which make me crazy.

I mean that the new CLI commands I introduce are not correctly handle. Some of them work fine and other one are simply not recognize even if help string are correctly handle. So, it is very hard to start correctly OSPF with segment routing enable. I must add extra code to force some commands.

So, tomorrow I will rebase my code on a fresh master branch to see if this problem will be solved.

In the mean time, I have one problem, but that seems general. I can't add a new FEC for a given prefix. Only MPLS label are correctly taken into account. I also try to setup a static route with a label i.e. more or less the same action I perform when trying to install a new FEC, and it also failed. I mean that all gosmoothly without any error, but, the prefix route is not install in the kernel. I will also try to use a fresh kernel (I'm currently using a 4.4.6) to see if improve things. Do you observe this problem ?

I will update my git tomorrow and proposed a first version of the PRfor review.

Regards

Olivier

Le 03/01/2018 à 16:40, Donald Sharp a écrit :
> Olivier -
>
> Thanks for pointing me at the code changes.  I've taken a look and
> added my review comments.  Let us know when it is ready to go.
>
> thanks!
>
> donlad
>
> On Fri, Dec 22, 2017 at 11:08 AM, Olivier Dugeon
> <olivier.dugeon at orange.com> wrote:
>> Hi Donald,
>>
>> OK. Thank you very much to give me more time.
>>
>> You could start having a look on my FRR fork:
>> https://github.com/Orange-OpenSource/frr/tree/SR-Routing
>>
>> I just push my code. But not yet ready for the Pull Request.
>>
>> In particular, I need to find a proper way to know that a re-routing occurs
>> i.e. that OSPF recompute / reinstall a new routing table in order to update
>> accordingly the Segment Routing MPLS FIB. I look to LDP code, but not found
>> useful information. Previously it was done by adding a hook when OSPF send
>> new routing table to Zebra, but I don't love too much this way of proceed.
>> If someone has a better idea, I'll take it with pleasure.
>>
>> Nothing will happen next week. I'll inform on progress first week of
>> January.
>>
>> Regards
>>
>> Olivier
>>
>>
>> Le 22/12/2017 à 16:48, Donald Sharp a écrit :
>>
>> Olivier -
>>
>> I think we'll wait. There are a couple of other issues we are trying
>> to resolve as well which have not happened yet.  Keep us updated!
>>
>> donald
>>
>> On Fri, Dec 22, 2017 at 9:07 AM,  <olivier.dugeon at orange.com> wrote:
>>
>> Hi Donald, all,
>>
>> Unfortunately, remaining bugs have won despite all my efforts and my best
>> wish. I have to throw in the towel by KO :-(
>>
>> I'm going on vacation for two weeks, and completely off between Christmas
>> and New Year. I will resume the fight early January and this time, I will
>> win the game.
>>
>> In the meantime, I will push in my personal FRR fork with SR-Routing branch
>> the code as it is in one or two hours. If anyone wants to take a look at it.
>>
>> https://github.com/Orange-OpenSource/frr
>>
>> I let you take the decision to create the branch 4.0 now or wait a little
>> longer.
>>
>> All my best wishes to you and your family.
>>
>> Regards
>>
>> Olivier
>>
>>
>> Le 20/12/2017 à 22:08, Donald Sharp a écrit :
>>
>> Olivier -
>>
>> We can wait.
>>
>> thanks!
>>
>> donald
>>
>> On Wed, Dec 20, 2017 at 1:10 PM, Olivier Dugeon
>> <olivier.dugeon at orange.com> wrote:
>>
>> Hello Donald,
>>
>> I just finish re-factoring my code on fresh frr/master.
>>
>> Now, I need to check indentation, update ospfd documentation for the new SR
>> CLI and perform my tests.
>>
>> Tomorrow, I have several meetings, so, I'll not finish all my tasks before
>> Friday.
>>
>> If it is too late, just skip it and publish 4.0 branch. I'll publish my PR
>> later, and we could decide if we backport it to the upcoming 4.0 release.
>>
>> Regards
>>
>> Olivier
>>
>>
>> Le 19/12/2017 à 19:36, Donald Sharp a écrit :
>>
>> Olivier -
>>
>> Any update here on your SR patch?
>>
>> donald
>>
>> On Wed, Dec 13, 2017 at 10:25 AM, Olivier Dugeon
>> <olivier.dugeon at orange.com> wrote:
>>
>> Hi Donald, all
>>
>> I hope finishing our Segment Routing patch by a week.
>>
>> So, is it possible to wait for it to be included in 4.0 branch ?
>>
>> Regards
>>
>> Olivier
>>
>>
>> Le 13/12/2017 à 14:04, Donald Sharp a écrit :
>>
>> I am currently waiting on PR #1533( Addition of Linux Realms ) to get
>> in in order to pull the 4.0 branch.  *IF* you want a feature to go in
>> to 4.0 this is your absolute last chance to make it happen.
>>
>> thanks!
>>
>> donald
>>
>> On Thu, Dec 7, 2017 at 10:45 AM, Donald Sharp
>> <sharpd at cumulusnetworks.com> wrote:
>>
>> All -
>>
>> I intend to pull the 4.0 branch early next week.  Now is the time for
>> any last minute additions before we create it.
>>
>> Additionally I would like to create a 3.0.3 version with bug-fixes by
>> the new years.  So if you are missing anything or have a bug fix
>> submitting it would be good.
>>
>> donald
>>
>> _______________________________________________
>> dev mailing list
>> dev at lists.frrouting.org
>> https://lists.frrouting.org/listinfo/dev
>>
>>
>>
>>
>> _________________________________________________________________________________________________________________________
>>
>> Ce message et ses pieces jointes peuvent contenir des informations
>> confidentielles ou privilegiees et ne doivent donc
>> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu
>> ce message par erreur, veuillez le signaler
>> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
>> electroniques etant susceptibles d'alteration,
>> Orange decline toute responsabilite si ce message a ete altere, deforme ou
>> falsifie. Merci.
>>
>> This message and its attachments may contain confidential or privileged
>> information that may be protected by law;
>> they should not be distributed, used or copied without authorisation.
>> If you have received this email in error, please notify the sender and
>> delete this message and its attachments.
>> As emails may be altered, Orange is not liable for messages that have been
>> modified, changed or falsified.
>> Thank you.
>>
>>

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.frrouting.org/pipermail/dev/attachments/20180111/45e7daf3/attachment.html>