[dev] New Defects reported by Coverity Scan for freerangerouting/frr
scan-admin at coverity.com
scan-admin at coverity.com
Tue Jan 23 20:41:30 EST 2018
Hi,
Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
8 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)
** CID 1464358: Control flow issues (DEADCODE)
/zebra/zebra_vty.c: 2107 in ipv6_route_magic()
________________________________________________________________________________________________________
*** CID 1464358: Control flow issues (DEADCODE)
/zebra/zebra_vty.c: 2107 in ipv6_route_magic()
2101 nexthop_vrf);
2102 return CMD_WARNING_CONFIG_FAILED;
2103 }
2104
2105 zvrf = zebra_vrf_lookup_by_name(vrf);
2106 if (!nh_zvrf) {
>>> CID 1464358: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, "%% nexthop vr...".
2107 vty_out(vty, "%% nexthop vrf %s is not defined\n",
2108 vrf);
2109 return CMD_WARNING_CONFIG_FAILED;
2110 }
2111
2112 return zebra_static_route_leak(vty, zvrf, nh_zvrf,
** CID 1464357: Null pointer dereferences (FORWARD_NULL)
/zebra/zebra_vty_clippy.c: 192 in ip_route_blackhole_vrf()
________________________________________________________________________________________________________
*** CID 1464357: Null pointer dereferences (FORWARD_NULL)
/zebra/zebra_vty_clippy.c: 192 in ip_route_blackhole_vrf()
186 #if 7 /* anything to parse? */
187 int _i;
188 #if 1 /* anything that can fail? */
189 unsigned _fail = 0, _failcnt = 0;
190 #endif
191 const char *no = NULL;
>>> CID 1464357: Null pointer dereferences (FORWARD_NULL)
>>> Assigning: "prefix" = "NULL".
192 const char *prefix = NULL;
193 struct in_addr mask = { INADDR_ANY };
194 const char *mask_str = NULL;
195 const char *flag = NULL;
196 long tag = 0;
197 const char *tag_str = NULL;
** CID 1464356: Null pointer dereferences (FORWARD_NULL)
/zebra/zebra_vty_clippy.c: 1439 in ipv6_route_vrf()
________________________________________________________________________________________________________
*** CID 1464356: Null pointer dereferences (FORWARD_NULL)
/zebra/zebra_vty_clippy.c: 1439 in ipv6_route_vrf()
1433 int _i;
1434 #if 1 /* anything that can fail? */
1435 unsigned _fail = 0, _failcnt = 0;
1436 #endif
1437 const char *no = NULL;
1438 struct prefix_ipv6 prefix = { };
>>> CID 1464356: Null pointer dereferences (FORWARD_NULL)
>>> Assigning: "prefix_str" = "NULL".
1439 const char *prefix_str = NULL;
1440 struct prefix_ipv6 from = { };
1441 const char *from_str = NULL;
1442 struct in6_addr gate = IN6ADDR_ANY_INIT;
1443 const char *gate_str = NULL;
1444 const char *ifname = NULL;
** CID 1464355: Control flow issues (DEADCODE)
/zebra/zebra_vty.c: 2016 in ipv6_route_address_interface_magic()
________________________________________________________________________________________________________
*** CID 1464355: Control flow issues (DEADCODE)
/zebra/zebra_vty.c: 2016 in ipv6_route_address_interface_magic()
2010 nexthop_vrf);
2011 return CMD_WARNING_CONFIG_FAILED;
2012 }
2013
2014 zvrf = zebra_vrf_lookup_by_name(vrf);
2015 if (!nh_zvrf) {
>>> CID 1464355: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, "%% nexthop vr...".
2016 vty_out(vty, "%% nexthop vrf %s is not defined\n",
2017 vrf);
2018 return CMD_WARNING_CONFIG_FAILED;
2019 }
2020
2021 return zebra_static_route_leak(vty, zvrf, nh_zvrf,
** CID 1464354: Control flow issues (DEADCODE)
/zebra/zebra_vty.c: 591 in ip_route_magic()
________________________________________________________________________________________________________
*** CID 1464354: Control flow issues (DEADCODE)
/zebra/zebra_vty.c: 591 in ip_route_magic()
585 nexthop_vrf);
586 return CMD_WARNING_CONFIG_FAILED;
587 }
588
589 zvrf = zebra_vrf_lookup_by_name(vrf);
590 if (!nh_zvrf) {
>>> CID 1464354: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, "%% nexthop vr...".
591 vty_out(vty, "%% nexthop vrf %s is not defined\n",
592 vrf);
593 return CMD_WARNING_CONFIG_FAILED;
594 }
595
596 return zebra_static_route_leak(vty, zvrf, nh_zvrf,
** CID 1464353: Control flow issues (DEADCODE)
/zebra/zebra_vty.c: 487 in ip_route_address_interface_magic()
________________________________________________________________________________________________________
*** CID 1464353: Control flow issues (DEADCODE)
/zebra/zebra_vty.c: 487 in ip_route_address_interface_magic()
481 nexthop_vrf);
482 return CMD_WARNING_CONFIG_FAILED;
483 }
484
485 zvrf = zebra_vrf_lookup_by_name(vrf);
486 if (!nh_zvrf) {
>>> CID 1464353: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "vty_out(vty, "%% nexthop vr...".
487 vty_out(vty, "%% nexthop vrf %s is not defined\n",
488 vrf);
489 return CMD_WARNING_CONFIG_FAILED;
490 }
491
492 return zebra_static_route_leak(vty, zvrf, nh_zvrf,
** CID 1464352: Null pointer dereferences (FORWARD_NULL)
/zebra/zebra_vty_clippy.c: 1230 in ipv6_route_address_interface_vrf()
________________________________________________________________________________________________________
*** CID 1464352: Null pointer dereferences (FORWARD_NULL)
/zebra/zebra_vty_clippy.c: 1230 in ipv6_route_address_interface_vrf()
1224 int _i;
1225 #if 1 /* anything that can fail? */
1226 unsigned _fail = 0, _failcnt = 0;
1227 #endif
1228 const char *no = NULL;
1229 struct prefix_ipv6 prefix = { };
>>> CID 1464352: Null pointer dereferences (FORWARD_NULL)
>>> Assigning: "prefix_str" = "NULL".
1230 const char *prefix_str = NULL;
1231 struct prefix_ipv6 from = { };
1232 const char *from_str = NULL;
1233 struct in6_addr gate = IN6ADDR_ANY_INIT;
1234 const char *gate_str = NULL;
1235 const char *ifname = NULL;
** CID 1464351: Null pointer dereferences (FORWARD_NULL)
/zebra/zebra_vty_clippy.c: 1031 in ipv6_route_blackhole_vrf()
________________________________________________________________________________________________________
*** CID 1464351: Null pointer dereferences (FORWARD_NULL)
/zebra/zebra_vty_clippy.c: 1031 in ipv6_route_blackhole_vrf()
1025 int _i;
1026 #if 1 /* anything that can fail? */
1027 unsigned _fail = 0, _failcnt = 0;
1028 #endif
1029 const char *no = NULL;
1030 struct prefix_ipv6 prefix = { };
>>> CID 1464351: Null pointer dereferences (FORWARD_NULL)
>>> Assigning: "prefix_str" = "NULL".
1031 const char *prefix_str = NULL;
1032 struct prefix_ipv6 from = { };
1033 const char *from_str = NULL;
1034 const char *flag = NULL;
1035 long tag = 0;
1036 const char *tag_str = NULL;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJn-2B-2FLIrBbTGjh5kz8PsuSvPEeahHqSwOJU6X-2Fkqa0O5-2FreHau0BUuIG3HVUoxwKU-2BG4ibfsjKz5jlTOh4Yb-2Fkm7OwqSpstLwVJDKFZcEclT6UNwyiIqcYeqZsyUSXV-2BDkz9TCHRY9dRDDdyocrGQPr14meMafOwkDKXG-2BxOrK98zQ-3D-3D
To manage Coverity Scan email notifications for "frr at lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4lcTWm1Zma8LQDNpOYqrETKrqBiM18kcBcL8b08LzBPOYJYGySZ4Vv7d5QYcnSbGxl3QyORKgEmDxh-2BE2mj6dp1V4JSs2jbMZuLnEQJOW0Z0-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJn-2B-2FLIrBbTGjh5kz8PsuSvPTJFmECNy-2F-2FSj7QK44KsTElDn7A6K3mc4tsyeMynlbPG-2BY8dchYWlwosgDhzGtaLZalByjtWhb-2BEOoYU-2BzhsxobyepBYvu33nFIO3tdx02q33t-2BOlCcAEWZccoQ-2B0lpZ3lISuY12Bs19XezfW0tx1Gg-3D-3D
More information about the dev
mailing list