[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1465852:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1465852:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_vty_clippy.c: 356 in af_route_map_vpn_imexport()
350     	}
351     #if 0 /* anything that can fail? */
352     	if (_failcnt)
353     		return CMD_WARNING;
354     #endif
355     #endif
>>>     CID 1465852:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "direction_str" to "af_route_map_vpn_imexport_magic", which dereferences it.
356     	return af_route_map_vpn_imexport_magic(self, vty, argc, argv, no, direction_str, rmap_str);
357     }
358     
359     /* bgp_imexport_vpn => "[no] <import|export>$direction_str vpn" */
360     DEFUN_CMD_FUNC_DECL(bgp_imexport_vpn)
361     #define funcdecl_bgp_imexport_vpn static int bgp_imexport_vpn_magic(\

** CID 1465851:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1465851:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_vty_clippy.c: 404 in bgp_imexport_vpn()
398     	}
399     #if 0 /* anything that can fail? */
400     	if (_failcnt)
401     		return CMD_WARNING;
402     #endif
403     #endif
>>>     CID 1465851:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "direction_str" to "bgp_imexport_vpn_magic", which dereferences it.
404     	return bgp_imexport_vpn_magic(self, vty, argc, argv, no, direction_str);
405     }
406     
407     /* show_ip_bgp_instance_updgrps_adj_s => "show [ip]$ip bgp [<view|vrf> VIEWVRFNAME$vrf] [<ipv4|ipv6>$afi <unicast|multicast|vpn>$safi] update-groups [SUBGROUP-ID]$sgid <advertise-queue|advertised-routes|packet-queue>$rtq" */
408     DEFUN_CMD_FUNC_DECL(show_ip_bgp_instance_updgrps_adj_s)
409     #define funcdecl_show_ip_bgp_instance_updgrps_adj_s static int show_ip_bgp_instance_updgrps_adj_s_magic(\

** CID 1465850:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1465850:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_vty_clippy.c: 250 in af_nexthop_vpn_export()
244     	}
245     #if 1 /* anything that can fail? */
246     	if (_failcnt)
247     		return CMD_WARNING;
248     #endif
249     #endif
>>>     CID 1465850:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "nexthop_str" to "af_nexthop_vpn_export_magic", which dereferences it.
250     	return af_nexthop_vpn_export_magic(self, vty, argc, argv, no, nexthop_str, nexthop_str_str);
251     }
252     
253     /* af_rt_vpn_imexport => "[no] <rt|route-target> vpn <import|export|both>$direction_str RTLIST..." */
254     DEFUN_CMD_FUNC_DECL(af_rt_vpn_imexport)
255     #define funcdecl_af_rt_vpn_imexport static int af_rt_vpn_imexport_magic(\

** CID 1465849:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1465849:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_vty_clippy.c: 138 in af_rd_vpn_export()
132     	}
133     #if 0 /* anything that can fail? */
134     	if (_failcnt)
135     		return CMD_WARNING;
136     #endif
137     #endif
>>>     CID 1465849:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "rd_str" to "af_rd_vpn_export_magic", which dereferences it.
138     	return af_rd_vpn_export_magic(self, vty, argc, argv, no, rd_str);
139     }
140     
141     /* af_label_vpn_export => "[no] label vpn export (0-1048575)$label_val" */
142     DEFUN_CMD_FUNC_DECL(af_label_vpn_export)
143     #define funcdecl_af_label_vpn_export static int af_label_vpn_export_magic(\

** CID 1465848:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1465848:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_vty_clippy.c: 303 in af_rt_vpn_imexport()
297     	}
298     #if 0 /* anything that can fail? */
299     	if (_failcnt)
300     		return CMD_WARNING;
301     #endif
302     #endif
>>>     CID 1465848:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "direction_str" to "af_rt_vpn_imexport_magic", which dereferences it.
303     	return af_rt_vpn_imexport_magic(self, vty, argc, argv, no, direction_str, rtlist);
304     }
305     
306     /* af_route_map_vpn_imexport => "[no] route-map vpn <import|export>$direction_str RMAP$rmap_str" */
307     DEFUN_CMD_FUNC_DECL(af_route_map_vpn_imexport)
308     #define funcdecl_af_route_map_vpn_imexport static int af_route_map_vpn_imexport_magic(\


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJnuHIVY2TiqwR5YisSQuzsY6p0t5ngT6Vyiixi9yu9dnTOfIBmKR2QguY7QAS-2BYWuUKEPvNyQG-2BCIKuNEvVL5GkVeYhsyAxGtFUg39UJqRv1cpntRyY9rl4H47Rihe5V4Wlp-2BizgtbWImU8Lau-2FT1VuZL9oYSyDhRcELqgMC7D6Rw-3D-3D