[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1466892:  Incorrect expression  (COPY_PASTE_ERROR)
/bgpd/bgp_route.c: 570 in bgp_info_cmp()


________________________________________________________________________________________________________
*** CID 1466892:  Incorrect expression  (COPY_PASTE_ERROR)
/bgpd/bgp_route.c: 570 in bgp_info_cmp()
564     				"%s: %s wins over %s due to preferred BGP_ROUTE type",
565     				pfx_buf, new_buf, exist_buf);
566     		return 1;
567     	}
568     
569     	if (!(exist->sub_type == BGP_ROUTE_NORMAL ||
>>>     CID 1466892:  Incorrect expression  (COPY_PASTE_ERROR)
>>>     "new" in "new->sub_type" looks like a copy-paste error.
570     	      new->sub_type == BGP_ROUTE_IMPORTED)) {
571     		if (debug)
572     			zlog_debug(
573     				"%s: %s loses to %s due to preferred BGP_ROUTE type",
574     				pfx_buf, new_buf, exist_buf);
575     		return 0;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJnAl6n43vWco4Hrvtoyyirv2kFqjGI0Vgta3HhXaJdpeLfYCjaY4rTghFIMuN5XYYWNNlZsWrijHdMTxGH-2FtIj-2BnDyut5OygAi5YxZfAm8aSiglKW4o4Qs7a1J3eV7WDP8Ldb4w5z7i0c0dweyR2m0rBb1w3AOtvAJiw4ebb1BXAg-3D-3D