[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1474171:  Incorrect expression  (USELESS_CALL)


________________________________________________________________________________________________________
*** CID 1474171:  Incorrect expression  (USELESS_CALL)
/bgpd/bgp_mpath.c: 613 in bgp_path_info_mpath_update()
607     			assert(new_mpath);
608     			assert(prev_mpath);
609     			if ((mpath_count < maxpaths) && (new_mpath != new_best)
610     			    && bgp_path_info_nexthop_cmp(prev_mpath,
611     							 new_mpath)) {
612     				if (new_mpath == next_mpath)
>>>     CID 1474171:  Incorrect expression  (USELESS_CALL)
>>>     Calling "bgp_path_info_mpath_next(new_mpath)" is only useful for its return value, which is ignored.
613     					bgp_path_info_mpath_next(new_mpath);
614     				bgp_path_info_mpath_dequeue(new_mpath);
615     
616     				bgp_path_info_mpath_enqueue(prev_mpath,
617     							    new_mpath);
618     				prev_mpath = new_mpath;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkBkSQZ4-2FOMKUzuIfSw1Vj9KgR1-2Bgq-2FWYpnnRxLGpUXOfwAki8XdfjA2KzZKq9Wc8huclGVfiJXpFzsEdHJ-2B7MMlMxyeBIIZiDO-2Fzox54ezJxUsaqr2QIuLMjBeJ6DgHDtnR69qXh-2F2x14h01F6pMPCe5aIbN-2BtkDwWujnxL2XwAg-3D-3D