[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1475200:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1475200:  Null pointer dereferences  (FORWARD_NULL)
/sharpd/sharp_vty_clippy.c: 235 in vrf_label()
229     	}
230     #if 1 /* anything that can fail? */
231     	if (_failcnt)
232     		return CMD_WARNING;
233     #endif
234     #endif
>>>     CID 1475200:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "name" to "vrf_label_magic", which dereferences it.
235     	return vrf_label_magic(self, vty, argc, argv, ipv4, ipv6, name, label, label_str);
236     }
237     
238     /* remove_routes => "sharp remove routes A.B.C.D$start (1-1000000)$routes [instance (0-255)$instance]" */
239     DEFUN_CMD_FUNC_DECL(remove_routes)
240     #define funcdecl_remove_routes static int remove_routes_magic(\

** CID 1475199:  Error handling issues  (CHECKED_RETURN)
/pbrd/pbr_zebra.c: 364 in pbr_zebra_nexthop_update()


________________________________________________________________________________________________________
*** CID 1475199:  Error handling issues  (CHECKED_RETURN)
/pbrd/pbr_zebra.c: 364 in pbr_zebra_nexthop_update()
358     				    zebra_size_t length, vrf_id_t vrf_id)
359     {
360     	struct zapi_route nhr;
361     	char buf[PREFIX2STR_BUFFER];
362     	uint32_t i;
363     
>>>     CID 1475199:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "zapi_nexthop_update_decode" without checking return value (as is done elsewhere 4 out of 5 times).
364     	zapi_nexthop_update_decode(zclient->ibuf, &nhr);
365     
366     	if (DEBUG_MODE_CHECK(&pbr_dbg_zebra, DEBUG_MODE_ALL)) {
367     
368     		DEBUGD(&pbr_dbg_zebra, "%s: Received Nexthop update: %s",
369     		       __PRETTY_FUNCTION__,

** CID 1475198:  Error handling issues  (CHECKED_RETURN)
/sharpd/sharp_zebra.c: 226 in sharp_zebra_nexthop_watch()


________________________________________________________________________________________________________
*** CID 1475198:  Error handling issues  (CHECKED_RETURN)
/sharpd/sharp_zebra.c: 226 in sharp_zebra_nexthop_watch()
220     {
221     	int command = ZEBRA_NEXTHOP_REGISTER;
222     
223     	if (!watch)
224     		command = ZEBRA_NEXTHOP_UNREGISTER;
225     
>>>     CID 1475198:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "zclient_send_rnh" without checking return value (as is done elsewhere 4 out of 5 times).
226     	zclient_send_rnh(zclient, command, p, true, VRF_DEFAULT);
227     }
228     
229     static int sharp_nexthop_update(int command, struct zclient *zclient,
230     				zebra_size_t length, vrf_id_t vrf_id)
231     {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJm4WzvvCk-2BvdEH6wL-2FV-2B70KPDdzYXWrATu7IpQuwqar71S-2FFFDLnnE54WkEi-2FrKA5oaVZ7ULBHkiGij03PRBjxuqkVzcob3DQNkELLZmnl6RGxwb-2BnKYDmRkatvIt-2BxhGk4YsbCBC6KrQuhbX6-2BooB2uzsnLhlBfIoOC8FbByeFTQ-3D-3D