[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1473286:  Memory - corruptions  (OVERRUN)


________________________________________________________________________________________________________
*** CID 1473286:  Memory - corruptions  (OVERRUN)
/isisd/isis_spf.c: 1070 in isis_spf_loop()
1064     		add_to_paths(spftree, vertex);
1065     		if (!VTYPE_IS(vertex->type))
1066     			continue;
1067     
1068     		lsp = lsp_for_vertex(spftree, vertex);
1069     		if (!lsp) {
>>>     CID 1473286:  Memory - corruptions  (OVERRUN)
>>>     Overrunning array "vertex->N.id" of 7 bytes by passing it to a function which accesses it at byte offset 7.
1070     			zlog_warn("ISIS-Spf: No LSP found for %s",
1071     				  rawlspid_print(vertex->N.id)); /* FIXME */
1072     			continue;
1073     		}
1074     
1075     		isis_spf_process_lsp(spftree, lsp, vertex->d_N, vertex->depth,

** CID 1473285:  Null pointer dereferences  (FORWARD_NULL)
/isisd/isis_lsp.c: 1909 in lsp_tick()


________________________________________________________________________________________________________
*** CID 1473285:  Null pointer dereferences  (FORWARD_NULL)
/isisd/isis_lsp.c: 1909 in lsp_tick()
1903     					lsp = NULL;
1904     					dict_delete_free(area->lspdb[level],
1905     							 dnode);
1906     				}
1907     
1908     				if (fabricd_init_c) {
>>>     CID 1473285:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "lsp".
1909     					fabricd_sync_incomplete |=
1910     						ISIS_CHECK_FLAG(lsp->SSNflags,
1911     								fabricd_init_c);
1912     				}
1913     			}
1914     		}


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeHs8691VOJpZofPkpp-2BRBqc-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJlps6did7Hgj98j5iH7FEeaB2Zumk8LjfFRVWO-2FD2fhid6yNMT-2BfLphefpYPoERFGJfUGJp27KPuGMaoP0toY5VY27ILX2IZo91jbhpF0rRS2SMMWIxcAdUiV5RAZtWOURZhx-2FSUKRZN8gmJ9KgRgNbMwCL1yxndeoPjzH-2BlX36pQ-3D-3D