[dev] New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1479148:  Incorrect expression  (COPY_PASTE_ERROR)
/zebra/zebra_rib.c: 1935 in rib_process_result()


________________________________________________________________________________________________________
*** CID 1479148:  Incorrect expression  (COPY_PASTE_ERROR)
/zebra/zebra_rib.c: 1935 in rib_process_result()
1929     		if (old_re->dplane_sequence != dplane_ctx_get_old_seq(ctx)) {
1930     			if (IS_ZEBRA_DEBUG_DPLANE_DETAIL)
1931     				zlog_debug("%u:%s Stale dplane result for old_re %p",
1932     					   dplane_ctx_get_vrf(ctx),
1933     					   dest_str, old_re);
1934     		} else
>>>     CID 1479148:  Incorrect expression  (COPY_PASTE_ERROR)
>>>     "re" in "re->status" looks like a copy-paste error.
1935     			UNSET_FLAG(re->status, ROUTE_ENTRY_QUEUED);
1936     	}
1937     
1938     	switch (op) {
1939     	case DPLANE_OP_ROUTE_INSTALL:
1940     	case DPLANE_OP_ROUTE_UPDATE:

** CID 1479146:  Null pointer dereferences  (FORWARD_NULL)
/zebra/zebra_rib.c: 1935 in rib_process_result()


________________________________________________________________________________________________________
*** CID 1479146:  Null pointer dereferences  (FORWARD_NULL)
/zebra/zebra_rib.c: 1935 in rib_process_result()
1929     		if (old_re->dplane_sequence != dplane_ctx_get_old_seq(ctx)) {
1930     			if (IS_ZEBRA_DEBUG_DPLANE_DETAIL)
1931     				zlog_debug("%u:%s Stale dplane result for old_re %p",
1932     					   dplane_ctx_get_vrf(ctx),
1933     					   dest_str, old_re);
1934     		} else
>>>     CID 1479146:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "re".
1935     			UNSET_FLAG(re->status, ROUTE_ENTRY_QUEUED);
1936     	}
1937     
1938     	switch (op) {
1939     	case DPLANE_OP_ROUTE_INSTALL:
1940     	case DPLANE_OP_ROUTE_UPDATE:


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRa7dJ8klHLUFWVd2fqpS-2B-2FHaN43B-2FQ11ntcKmbKat2WeDU1AdI-2FBBrnda9ub5tlg3U-3D_d-2Fi2nRutHp-2FDWtw8JRg-2Bc1m9CS4-2B5uVbodfDyLsp-2FJkVU1c-2FbhnElc-2F2Zu2s1Iqu9NW3e8MCYnwEzldbHCQLjEhabQ1NIUGJSP64iv0sH86pCdEbBXCUSS-2BVWOPCpl4KdXxTzQVhRoe12sjCg47vgTEnQm-2BrC6dWoYXLp8UXKSEAQ-2BGzERQjlIfVd2txoEkclSIFhAk7MId2RkxeYLCTwg-3D-3D