New Defects reported by Coverity Scan for freerangerouting/frr
scan-admin at coverity.com
scan-admin at coverity.com
Fri Aug 21 00:07:23 UTC 2020
Hi,
Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
56 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1496687: Error handling issues (CHECKED_RETURN)
/vrrpd/vrrp_packet.c: 95 in vrrp_pkt_checksum()
________________________________________________________________________________________________________
*** CID 1496687: Error handling issues (CHECKED_RETURN)
/vrrpd/vrrp_packet.c: 95 in vrrp_pkt_checksum()
89 ph.next_hdr = IPPROTO_VRRP;
90 chksum = in_cksum_with_ph6(&ph, pkt, pktsize);
91 } else if (!v6 && ((pkt->hdr.vertype >> 4) == 3)) {
92 struct ipv4_ph ph = {};
93
94 ph.src = src->ipaddr_v4;
>>> CID 1496687: Error handling issues (CHECKED_RETURN)
>>> Calling "inet_pton" without checking return value (as is done elsewhere 15 out of 16 times).
95 inet_pton(AF_INET, VRRP_MCASTV4_GROUP_STR, &ph.dst);
96 ph.proto = IPPROTO_VRRP;
97 ph.len = htons(pktsize);
98 chksum = in_cksum_with_ph4(&ph, pkt, pktsize);
99 } else if (!v6 && ((pkt->hdr.vertype >> 4) == 2)) {
100 chksum = in_cksum(pkt, pktsize);
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DcOva_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTy49BBayn3ktqTBZiqyHJPM2SniEKhJ6zVMgWvKutg8eX6JK3kPWLXe1-2F5C4NRfO1Eo08FqnkP5uVkpbMC9kIfHQi93tQI1ViAFPMs9hBaZRaQtaYcoeyA49V5Zc9VwVZOx-2FACN3DsSPZi5D1CQbI2heXKs1gLZJqnt44c-2FUsVUVTlSoI2YqilI3gLxMDEY67U-3D
More information about the dev
mailing list