New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1496314:  Null pointer dereferences  (REVERSE_INULL)
/isisd/isis_circuit.c: 724 in isis_circuit_down()


________________________________________________________________________________________________________
*** CID 1496314:  Null pointer dereferences  (REVERSE_INULL)
/isisd/isis_circuit.c: 724 in isis_circuit_down()
718     #ifndef FABRICD
719     	/* send northbound notification */
720     	isis_notif_if_state_change(circuit, true);
721     #endif /* ifndef FABRICD */
722     
723     	/* log adjacency changes if configured to do so */
>>>     CID 1496314:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "circuit->area" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
724     	if (circuit->area && circuit->area->log_adj_changes) {
725     		struct isis_adjacency *adj = NULL;
726     		if (circuit->circ_type == CIRCUIT_T_P2P) {
727     			adj = circuit->u.p2p.neighbor;
728     			if (adj)
729     				isis_log_adj_change(

** CID 1496313:  Null pointer dereferences  (NULL_RETURNS)


________________________________________________________________________________________________________
*** CID 1496313:  Null pointer dereferences  (NULL_RETURNS)
/bgpd/bgp_bmp.c: 959 in bmp_wrsync()
953     		 */
954     		if (!bmp->syncrdpos)
955     			bmp->syncrdpos = bgp_table_top(table);
956     
957     		/* look for a valid mid-layer table */
958     		do {
>>>     CID 1496313:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "bmp->syncrdpos" when calling "bgp_dest_get_bgp_table_info".
959     			table = bgp_dest_get_bgp_table_info(bmp->syncrdpos);
960     			if (table) {
961     				break;
962     			}
963     			bmp->syncrdpos = bgp_route_next(bmp->syncrdpos);
964     		} while (bmp->syncrdpos);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPklAc1eEA-2F1zfUjH6teEwtXAn74UdOrNjckt5W0LJ0CDxXoQFnSJSV51LhpQIExOPuUyDQ-2BIaYqt88E1d5-2F-2Fc-3D8EJs_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTxbku5RU3cEVrtG23u8jI3CXCjMdKRwtrLipxKPRghnPiPjTGAZpJqDPE9AfQu3JlkL9nGCGOYYBCNvS9jpV5GFaPtsFsheOAIJBXrH0HH08RHVcd9az1ejLdTrzdRgyrKHhx1S6Vfy4sh-2Brr5ShMdKkjAWXkmIpK4tgTuMx2kgpPfkKOb6qAK4zYYZ2FEP27I-3D