New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1496495:  Error handling issues  (CHECKED_RETURN)
/zebra/zebra_dplane.c: 2539 in dplane_route_notif_update()


________________________________________________________________________________________________________
*** CID 1496495:  Error handling issues  (CHECKED_RETURN)
/zebra/zebra_dplane.c: 2539 in dplane_route_notif_update()
2533     	}
2534     
2535     	/* Capture info about the source of the notification, in 'ctx' */
2536     	dplane_ctx_set_notif_provider(new_ctx,
2537     				      dplane_ctx_get_notif_provider(ctx));
2538     
>>>     CID 1496495:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "dplane_update_enqueue" without checking return value (as is done elsewhere 9 out of 10 times).
2539     	dplane_update_enqueue(new_ctx);
2540     
2541     	ret = ZEBRA_DPLANE_REQUEST_QUEUED;
2542     
2543     done:
2544     	return ret;

** CID 1496494:  Null pointer dereferences  (NULL_RETURNS)
/zebra/zebra_nb_config.c: 1221 in lib_vrf_zebra_l3vni_id_modify()


________________________________________________________________________________________________________
*** CID 1496494:  Null pointer dereferences  (NULL_RETURNS)
/zebra/zebra_nb_config.c: 1221 in lib_vrf_zebra_l3vni_id_modify()
1215     		 * if zebra vrf already mapped to different vni id.
1216     		 */
1217     		pn_dnode = yang_dnode_get_parent(args->dnode, "vrf");
1218     		if (pn_dnode) {
1219     			vrfname = yang_dnode_get_string(pn_dnode, "./name");
1220     			vrf = vrf_lookup_by_name(vrfname);
>>>     CID 1496494:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing "vrf", which is known to be "NULL".
1221     			zvrf = zebra_vrf_lookup_by_id(vrf->vrf_id);
1222     			if (zvrf->l3vni && zvrf->l3vni != vni) {
1223     				zlog_debug(
1224     					"vni %u cannot be configured as vni %u is already configured under the vrf",
1225     					vni, zvrf->l3vni);
1226     				return NB_ERR_VALIDATION;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DMXy0_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTxkREBG4QONnm2-2Fv6tqhYFUai-2B8owZl4LH-2F3h9Q2XTBnVXZ1Llo8uLCWsJauKqjdYsxATyS4XMv-2B3e-2Fsiz-2FFyo95j0LIWXyi5kmPT2ZBHzBEvrmRJtFzfSjTatSoXhHPZDu9KQaiCUrd0vG6l5sa0T3L452nJ505oQ3UhiTVxif6uZOLdtTyl7484sEjzThboM-3D