New Defects reported by Coverity Scan for freerangerouting/frr

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1499389:  Null pointer dereferences  (NULL_RETURNS)
/bgpd/bgp_nb_config.c: 6280 in bgp_peer_group_peer_lookup()


________________________________________________________________________________________________________
*** CID 1499389:  Null pointer dereferences  (NULL_RETURNS)
/bgpd/bgp_nb_config.c: 6280 in bgp_peer_group_peer_lookup()
6274     					       const char *peer_str)
6275     {
6276     	struct peer *peer = NULL;
6277     	struct peer_group *group = NULL;
6278     
6279     	group = peer_group_lookup(bgp, peer_str);
>>>     CID 1499389:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing "group", which is known to be "NULL".
6280     	return peer = group->conf;
6281     }
6282     
6283     /*
6284      * XPath:
6285      * /frr-routing:routing/control-plane-protocols/control-plane-protocol/frr-bgp:bgp/peer-groups/peer-group

** CID 1499388:  Null pointer dereferences  (NULL_RETURNS)


________________________________________________________________________________________________________
*** CID 1499388:  Null pointer dereferences  (NULL_RETURNS)
/bgpd/bgp_nb_config.c: 5201 in bgp_neighbors_unnumbered_neighbor_neighbor_remote_as_remote_as_type_destroy()
5195     		bgp = nb_running_get_entry(args->dnode, NULL, true);
5196     		peer_str =
5197     			yang_dnode_get_string(args->dnode, "../../interface");
5198     		peer = peer_lookup_by_conf_if(bgp, peer_str);
5199     
5200     		/* remote-as set to 0 and as_type to unspecified */
>>>     CID 1499388:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "peer" when calling "peer_as_change".
5201     		peer_as_change(peer, 0, AS_UNSPECIFIED);
5202     
5203     		break;
5204     	}
5205     
5206     	return NB_OK;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DZj7I_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTxjmyV-2B50US6WUwqymV0smYEAK5eyfqpbzKpd3D3-2FNVwrW9Bm4Xti4IRItV5h5rwG0YvXB8nMsUKrQv5WU8ZgW-2BEILI1wxFihRMSK5ktNDF6WT2ZiRI-2BA9FW3b3XO5RxLE8Zz-2FkYmsPiBn6yUxbsfE8tOICe4JxlM7nB1I6IwsQqGNkQZbiyQKTZT3-2Bn-2BbOZjw-3D