New Defects reported by Coverity Scan for freerangerouting/frr

scan-admin at coverity.com scan-admin at coverity.com
Thu Sep 10 12:03:58 UTC 2020


Hi,

Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan.

5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1496950:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1496950:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_route.c: 4403 in bgp_soft_reconfig_table()
4397     			if (pi)
4398     				memcpy(&evpn, &pi->attr->evpn_overlay,
4399     				       sizeof(evpn));
4400     			else
4401     				memset(&evpn, 0, sizeof(evpn));
4402     
>>>     CID 1496950:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "label_pnt" to "bgp_update", which dereferences it.
4403     			ret = bgp_update(peer, bgp_dest_get_prefix(dest),
4404     					 ain->addpath_rx_id, ain->attr, afi,
4405     					 safi, ZEBRA_ROUTE_BGP,
4406     					 BGP_ROUTE_NORMAL, prd, label_pnt,
4407     					 num_labels, 1, &evpn);
4408     

** CID 1496949:  Null pointer dereferences  (REVERSE_INULL)
/isisd/isis_cli.c: 329 in ip6_router_isis_magic()


________________________________________________________________________________________________________
*** CID 1496949:  Null pointer dereferences  (REVERSE_INULL)
/isisd/isis_cli.c: 329 in ip6_router_isis_magic()
323     				      NB_OP_MODIFY, "true");
324     		nb_cli_enqueue_change(vty, "./frr-isisd:isis/circuit-type",
325     				      NB_OP_MODIFY, circ_type);
326     	}
327     
328     	/* check if the interface is a loopback and if so set it as passive */
>>>     CID 1496949:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "ifp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
329     	if (ifp && if_is_loopback(ifp))
330     		nb_cli_enqueue_change(vty, "./frr-isisd:isis/passive",
331     				      NB_OP_MODIFY, "true");
332     
333     	return nb_cli_apply_changes(vty, NULL);
334     }

** CID 1496948:  Null pointer dereferences  (REVERSE_INULL)
/isisd/isis_cli.c: 238 in ip_router_isis_magic()


________________________________________________________________________________________________________
*** CID 1496948:  Null pointer dereferences  (REVERSE_INULL)
/isisd/isis_cli.c: 238 in ip_router_isis_magic()
232     				      NB_OP_MODIFY, "true");
233     		nb_cli_enqueue_change(vty, "./frr-isisd:isis/circuit-type",
234     				      NB_OP_MODIFY, circ_type);
235     	}
236     
237     	/* check if the interface is a loopback and if so set it as passive */
>>>     CID 1496948:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "ifp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
238     	if (ifp && if_is_loopback(ifp))
239     		nb_cli_enqueue_change(vty, "./frr-isisd:isis/passive",
240     				      NB_OP_MODIFY, "true");
241     
242     	return nb_cli_apply_changes(vty, NULL);
243     }

** CID 1496947:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1496947:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_rpki.c: 445 in revalidate_bgp_node()
439     		uint32_t num_labels = 0;
440     
441     		if (path && path->extra) {
442     			label = path->extra->label;
443     			num_labels = path->extra->num_labels;
444     		}
>>>     CID 1496947:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "label" to "bgp_update", which dereferences it.
445     		ret = bgp_update(ain->peer, bgp_dest_get_prefix(bgp_dest),
446     				 ain->addpath_rx_id, ain->attr, afi, safi,
447     				 ZEBRA_ROUTE_BGP, BGP_ROUTE_NORMAL, NULL, label,
448     				 num_labels, 1, NULL);
449     
450     		if (ret < 0)

** CID 1496946:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1496946:  Null pointer dereferences  (FORWARD_NULL)
/bgpd/bgp_mac.c: 213 in bgp_process_mac_rescan_table()
207     						   peer->host, pfx_buf);
208     				}
209     				continue;
210     			}
211     
212     			memcpy(&evpn, &pi->attr->evpn_overlay, sizeof(evpn));
>>>     CID 1496946:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "label_pnt" to "bgp_update", which dereferences it.
213     			int32_t ret = bgp_update(peer, p,
214     						 pi->addpath_rx_id,
215     						 pi->attr, AFI_L2VPN, SAFI_EVPN,
216     						 ZEBRA_ROUTE_BGP,
217     						 BGP_ROUTE_NORMAL, &prd,
218     						 label_pnt, num_labels,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrtN2DGUU98GYhjd55wXsXtw53zRK70R0agdV-2Fb7c45-2BkxBoZjryQtr5SpUD80NNfE-3DVp4K_O0IDF7c8sUs2B6kWTeWwAJZqriD5fgsfL8PAN30oQTxUM0FCJlXrAGuRiJfr-2BPD2Y1Z5lBxvpiBPc9AvmP-2BCKoOL3f0J6tFWuGRQUh0sbJ9jjUdthicgdk-2FsV75xr4BkP02cMwJQR54crGQO4feJ-2B3G5XOMivmnDk4SgaF9wlSCGSEyt8n7cDtXfH-2FZkmdm7gZAqKUpn3XaYnDWnDEmUGn0bfUdTynLAoXGyDmz6qhg-3D




More information about the dev mailing list